Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/logback 1701 newrule is ignored #681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −6
Open

Bugfix/logback 1701 newrule is ignored #681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b0684f
Do not ignore new rules when interpreting xml configuration
jaam Jun 22, 2023
36cda65
Minor
jaam Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions logback-core/src/main/java/ch/qos/logback/core/joran/spi/SimpleRuleStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,12 @@ public void addRule(ElementSelector elementSelector, Supplier<Action> actionSupp
}

public void addRule(ElementSelector elementSelector, String actionClassName) {
Action action = null;

try {
action = (Action) OptionHelper.instantiateByClassName(actionClassName, Action.class, context);
Action action = (Action) OptionHelper.instantiateByClassName(actionClassName, Action.class, context);
addRule(elementSelector, () -> action);
} catch (Exception e) {
addError("Could not instantiate class [" + actionClassName + "]", e);
}
if (action != null) {
// addRule(elementSelector, action);
}
}

// exact match has the highest priority
Expand Down