Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#755 XZ compression support added #823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kazimirm
Copy link

@kazimirm kazimirm commented Jun 14, 2024

This is the proposed changes to resolve issue #755 to add support for xz compression with default compression level. Recognizing the need for enhanced compression options, these changes aim to provide better compression.

Key points of this merge request:

  • Introduced xz compression support with the default compression level.
  • Ensured backward compatibility to avoid breaking existing functionality.
  • Added relevant tests to validate the new feature.

These changes were implemented conservatively to maintain stability, though there is potential for further refinement.

Please review the proposed changes. Feedback is welcome, and feel free to merge if everything looks good.

Thank you!

Signed-off-by: Marián Kažimír <mkazimir@newps.cz>
@alxdlv
Copy link

alxdlv commented Oct 9, 2024

@ceki can you review the PR?

CC @kazimirm

@ceki
Copy link
Member

ceki commented Oct 9, 2024

Why is xz better than the existing zip or gz compressions?

@alxdlv
Copy link

alxdlv commented Oct 9, 2024

@ceki XZ compression offers much higher compression ratio and efficiency than default compression of gz or zip

# ls -lAh
total 24M
-rw-r----- 1 user user 20M Oct  3 00:00 test.log
-rw-r--r-- 1 user user 3.6M Oct  3 00:00 archived.zip
-rw-r--r-- 1 user user 3.3M Oct  3 00:01 archived.gz
-rw-r----- 1 user user 626K Oct  3 00:03 archived.xz

Also XZ iz designed to handle large files more effectively than traditional GZIP/ZIP formats.

@psih0z
Copy link

psih0z commented Oct 22, 2024

Hi, @ceki do you have any plans to add this functionality? It is really needed.

@artyomlao
Copy link

artyomlao commented Oct 31, 2024

@ceki
Hi! May I ask when .xz support can be completed?

@ceki
Copy link
Member

ceki commented Dec 30, 2024

The PR requires the xz library to be on the classpath. This not something that we can impose on the unsuspecting users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants