Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline not skipping multiple violations of same reference #1226

Closed
gennadigennadigennadi opened this issue Jun 19, 2023 · 0 comments · Fixed by #1227
Closed

Baseline not skipping multiple violations of same reference #1226

gennadigennadigennadi opened this issue Jun 19, 2023 · 0 comments · Fixed by #1227

Comments

@gennadigennadigennadi
Copy link
Member

Reproducer: https://github.com/gennadigennadigennadi/deptrac/tree/reproducer-skipped-multiple-violations-in-one-file

deptrac:
  skip_violations:
    Qossmic\Deptrac\Core\Ast\Parser\Cache\AstFileReferenceFileCache:
      - Qossmic\Deptrac\Supportive\DependencyInjection\Exception\CacheFileException
 Reason                     Ast                                                                                                                                                             
 -------------------------- ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  DependsOnDisallowedLayer   Qossmic\Deptrac\Core\Ast\Parser\Cache\AstFileReferenceFileCache must not depend on Qossmic\Deptrac\Supportive\DependencyInjection\Exception\CacheFileException  
                             You are depending on token that is a part of a layer that you are not allowed to depend on. (DependencyInjection)                                               
                             /var/www/deptrac/src/Core/Ast/Parser/Cache/AstFileReferenceFileCache.php:139                                                                                    
 -------------------------- ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 


 -------------------- ----- 
  Report                    
 -------------------- ----- 
  Violations           1    
  Skipped violations   1    
  Uncovered            24   
  Allowed              347  
  Warnings             0    
  Errors               0    
 -------------------- ----- 


Process finished with exit code 1
gennadigennadigennadi added a commit to gennadigennadigennadi/deptrac that referenced this issue Jun 20, 2023
gennadigennadigennadi added a commit to gennadigennadigennadi/deptrac that referenced this issue Jun 20, 2023
gennadigennadigennadi added a commit to gennadigennadigennadi/deptrac that referenced this issue Jun 20, 2023
gennadigennadigennadi added a commit to gennadigennadigennadi/deptrac that referenced this issue Jun 21, 2023
gennadigennadigennadi added a commit to gennadigennadigennadi/deptrac that referenced this issue Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant