-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rector] Prepare PHP 7.2 downgrade + scoped release with Rector #1113
Conversation
@TomasVotruba don't worry about the failing |
@patrickkusebauch Thanks for the info... I was thinking about what is that for :) |
29d4c8e
to
6519338
Compare
6519338
to
74adeda
Compare
Hi, I'm trying to get to the scoper now, but it might get pretty complex as you're using it a sligtly differently. What do you think? If you're ok with it, this PR only prepares metafiles and is ready to merge ✔️ |
I think: "Tomáš has way more experience with Scoper than all of us combined. I defer to his expertise." I am absolutely happy. with just merging this. I would also be happy with you standardizing the Scoper usage to be more in line with other SA tools like Rector or PHPStan, if it makes your life easier. |
Thanks for your support 👍 |
It might take a few days for @dbrumann to get to it and merge it, but feel free to continue with a stacked commit on top of this PR for the next iteration of changes. |
Thank you! No rush, I'll wait. Have a lot of work on my plate 👍 |
A huge thank you @TomasVotruba for this. I really appreciate it. I will have a closer look at the changes soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Again, thank you very much. LGTM
'doctrine/annotations/lib/Doctrine/Common/Annotations/DocLexer.php', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, but could you add this file to the .php-cs-fixer.dist.php
?
Thanks to everyone involved. Any idea when we might get a release with 7.2 compat? |
@dbrumann told me he is looking into some potential (unconfirmed) bugs with the current state of |
Just for clarification, the upcoming release will not be compatible with 7.2. As I understood it, this PR is still preliminary and we can't hook the downgrade-script up to the pipeline, yet. See: #1113 (comment) |
@TomasVotruba could you have a look into it, so we can get at least get deptrac downgraded to php 7.4 ? |
To be honest, I lost the track after long waiting and now I'm focused elsewhere. But the downgrade is quite easy to add. Just replicate this one: |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [qossmic/deptrac](https://github.com/qossmic/deptrac) | `^2.0.0-alpha` -> `^2.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/qossmic%2fdeptrac/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/qossmic%2fdeptrac/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/qossmic%2fdeptrac/2.0.0-alpha/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/qossmic%2fdeptrac/2.0.0-alpha/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>qossmic/deptrac (qossmic/deptrac)</summary> ### [`v2.0.0`](https://github.com/qossmic/deptrac/releases/tag/2.0.0) [Compare Source](https://github.com/qossmic/deptrac/compare/2.0.0-alpha...2.0.0) #### What's Changed - Bundle open dependency updates together by [@​dbrumann](https://github.com/dbrumann) in [https://github.com/qossmic/deptrac/pull/1070](https://github.com/qossmic/deptrac/pull/1070) - Exception clean up by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1079](https://github.com/qossmic/deptrac/pull/1079) - Extension documentation by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/867](https://github.com/qossmic/deptrac/pull/867) - Installation guide improved and aligned. by [@​d4s6](https://github.com/d4s6) in [https://github.com/qossmic/deptrac/pull/1076](https://github.com/qossmic/deptrac/pull/1076) - Bump phpunit/phpunit from 9.5.27 to 9.5.28 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1080](https://github.com/qossmic/deptrac/pull/1080) - Bump phpstan/phpstan-symfony from 1.2.19 to 1.2.20 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1081](https://github.com/qossmic/deptrac/pull/1081) - Bump phpstan/phpstan from 1.9.11 to 1.9.13 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1083](https://github.com/qossmic/deptrac/pull/1083) - Use getOption instead getParameterOption on config file by [@​maciejkosiarski](https://github.com/maciejkosiarski) in [https://github.com/qossmic/deptrac/pull/1089](https://github.com/qossmic/deptrac/pull/1089) - Fix --help doesn't work if deptrac.yaml file is missing issue by [@​maciejkosiarski](https://github.com/maciejkosiarski) in [https://github.com/qossmic/deptrac/pull/1088](https://github.com/qossmic/deptrac/pull/1088) - Mutation coverage improvements by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1090](https://github.com/qossmic/deptrac/pull/1090) - Override --help input option and add throws annotation according to psalm audit by [@​maciejkosiarski](https://github.com/maciejkosiarski) in [https://github.com/qossmic/deptrac/pull/1092](https://github.com/qossmic/deptrac/pull/1092) - Bump phpstan/phpstan from 1.9.13 to 1.9.17 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1111](https://github.com/qossmic/deptrac/pull/1111) - Bump phpstan/phpdoc-parser from 1.15.3 to 1.16.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1110](https://github.com/qossmic/deptrac/pull/1110) - Bump friendsofphp/php-cs-fixer from 3.13.2 to 3.14.4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1109](https://github.com/qossmic/deptrac/pull/1109) - Bump phpunit/phpunit from 9.5.28 to 9.6.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1107](https://github.com/qossmic/deptrac/pull/1107) - Bump symfony/dependency-injection from 6.2.3 to 6.2.6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1108](https://github.com/qossmic/deptrac/pull/1108) - Bump phpstan/phpstan-symfony from 1.2.20 to 1.2.23 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1106](https://github.com/qossmic/deptrac/pull/1106) - Bump symfony/finder from 6.2.3 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1093](https://github.com/qossmic/deptrac/pull/1093) - Bump symfony/console from 6.2.3 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1101](https://github.com/qossmic/deptrac/pull/1101) - Bump symfony/filesystem from 6.2.0 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1100](https://github.com/qossmic/deptrac/pull/1100) - Bump symfony/yaml from 6.2.2 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1099](https://github.com/qossmic/deptrac/pull/1099) - Bump symfony/event-dispatcher from 6.2.2 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1097](https://github.com/qossmic/deptrac/pull/1097) - Bump symfony/config from 6.2.0 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1095](https://github.com/qossmic/deptrac/pull/1095) - Bump symfony/options-resolver from 6.2.0 to 6.2.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1094](https://github.com/qossmic/deptrac/pull/1094) - Bump nikic/php-parser from 4.15.2 to 4.15.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/qossmic/deptrac/pull/1087](https://github.com/qossmic/deptrac/pull/1087) - Updating Result generation by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1091](https://github.com/qossmic/deptrac/pull/1091) - Code hardening - solving baseline issues in SA tools by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1103](https://github.com/qossmic/deptrac/pull/1103) - \[rector] Prepare PHP 7.2 downgrade + scoped release with Rector by [@​TomasVotruba](https://github.com/TomasVotruba) in [https://github.com/qossmic/deptrac/pull/1113](https://github.com/qossmic/deptrac/pull/1113) - Updated CollectorInterface namespace in docs by [@​ariddlestone](https://github.com/ariddlestone) in [https://github.com/qossmic/deptrac/pull/1120](https://github.com/qossmic/deptrac/pull/1120) - Better Violations by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1105](https://github.com/qossmic/deptrac/pull/1105) - Update configuration.md typo by [@​gusdeboer](https://github.com/gusdeboer) in [https://github.com/qossmic/deptrac/pull/1140](https://github.com/qossmic/deptrac/pull/1140) - Update dependencies by [@​dbrumann](https://github.com/dbrumann) in [https://github.com/qossmic/deptrac/pull/1141](https://github.com/qossmic/deptrac/pull/1141) - Implement ConfigBuilder by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1002](https://github.com/qossmic/deptrac/pull/1002) - Add performance counters to ConsoleSubsriber by [@​rubenrubiob](https://github.com/rubenrubiob) in [https://github.com/qossmic/deptrac/pull/1162](https://github.com/qossmic/deptrac/pull/1162) - Migrated `debug:unused` command from deptrac-awesome by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1164](https://github.com/qossmic/deptrac/pull/1164) - Migrated `debug:dependencies` command from deptrac-awesome by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1165](https://github.com/qossmic/deptrac/pull/1165) - Combine updates by [@​dbrumann](https://github.com/dbrumann) in [https://github.com/qossmic/deptrac/pull/1171](https://github.com/qossmic/deptrac/pull/1171) - Sort make targets and introduce help by [@​dbrumann](https://github.com/dbrumann) in [https://github.com/qossmic/deptrac/pull/1176](https://github.com/qossmic/deptrac/pull/1176) - Composer Collector by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1174](https://github.com/qossmic/deptrac/pull/1174) - PoC blog by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1178](https://github.com/qossmic/deptrac/pull/1178) - add docker setup and move cache-files into .cache/ by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1185](https://github.com/qossmic/deptrac/pull/1185) - [#​1158](https://github.com/qossmic/deptrac/issues/1158) - only read file once for filereader by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1192](https://github.com/qossmic/deptrac/pull/1192) - [#​1158](https://github.com/qossmic/deptrac/issues/1158) - only init new ComposerFileParser once per composer.lock by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1193](https://github.com/qossmic/deptrac/pull/1193) - Call `SuperGlobalToken::allowedNames()` just once by [@​staabm](https://github.com/staabm) in [https://github.com/qossmic/deptrac/pull/1198](https://github.com/qossmic/deptrac/pull/1198) - Removing deprecations and other clean-up for new Major release by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1175](https://github.com/qossmic/deptrac/pull/1175) - Bump composer dep by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1216](https://github.com/qossmic/deptrac/pull/1216) - add php-cs-fixer rule "single_line_empty_body" by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1217](https://github.com/qossmic/deptrac/pull/1217) - Closes [https://github.com/qossmic/deptrac/issues/1191](https://github.com/qossmic/deptrac/issues/1191) by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1204](https://github.com/qossmic/deptrac/pull/1204) - fix [#​1226](https://github.com/qossmic/deptrac/issues/1226) - skipped multiple violations in one file by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1227](https://github.com/qossmic/deptrac/pull/1227) - "deptrac" as composer bin by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1238](https://github.com/qossmic/deptrac/pull/1238) - do not crash the GraphViz formatter if no config is given by [@​xabbuh](https://github.com/xabbuh) in [https://github.com/qossmic/deptrac/pull/1251](https://github.com/qossmic/deptrac/pull/1251) - Dev dependencies upgrade (PHPUnit & Psalm) by [@​patrickkusebauch](https://github.com/patrickkusebauch) in [https://github.com/qossmic/deptrac/pull/1252](https://github.com/qossmic/deptrac/pull/1252) - Docs: exclude_files also works on directories by [@​staabm](https://github.com/staabm) in [https://github.com/qossmic/deptrac/pull/1262](https://github.com/qossmic/deptrac/pull/1262) - Prevent excessive php-doc parsing in FileReferenceVisitor by [@​staabm](https://github.com/staabm) in [https://github.com/qossmic/deptrac/pull/1199](https://github.com/qossmic/deptrac/pull/1199) - Composer collector exception when package does not exist by [@​maciejkosiarski](https://github.com/maciejkosiarski) in [https://github.com/qossmic/deptrac/pull/1279](https://github.com/qossmic/deptrac/pull/1279) - Update dep by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1280](https://github.com/qossmic/deptrac/pull/1280) - Fix typo in the docs by [@​jdreesen](https://github.com/jdreesen) in [https://github.com/qossmic/deptrac/pull/1281](https://github.com/qossmic/deptrac/pull/1281) - Add creating of cache directory if not exists by [@​alexander-schranz](https://github.com/alexander-schranz) in [https://github.com/qossmic/deptrac/pull/1302](https://github.com/qossmic/deptrac/pull/1302) - Remove dollar signs from readme.md console examples by [@​that-guy-iain](https://github.com/that-guy-iain) in [https://github.com/qossmic/deptrac/pull/1325](https://github.com/qossmic/deptrac/pull/1325) - Bump PHP Parser version to support PHP 8.3 by [@​benr77](https://github.com/benr77) in [https://github.com/qossmic/deptrac/pull/1342](https://github.com/qossmic/deptrac/pull/1342) - bump composer.lock by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1344](https://github.com/qossmic/deptrac/pull/1344) - WIP: test scoped release by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1352](https://github.com/qossmic/deptrac/pull/1352) - update by [@​gennadigennadigennadi](https://github.com/gennadigennadigennadi) in [https://github.com/qossmic/deptrac/pull/1406](https://github.com/qossmic/deptrac/pull/1406) #### New Contributors - [@​d4s6](https://github.com/d4s6) made their first contribution in [https://github.com/qossmic/deptrac/pull/1076](https://github.com/qossmic/deptrac/pull/1076) - [@​maciejkosiarski](https://github.com/maciejkosiarski) made their first contribution in [https://github.com/qossmic/deptrac/pull/1089](https://github.com/qossmic/deptrac/pull/1089) - [@​TomasVotruba](https://github.com/TomasVotruba) made their first contribution in [https://github.com/qossmic/deptrac/pull/1113](https://github.com/qossmic/deptrac/pull/1113) - [@​ariddlestone](https://github.com/ariddlestone) made their first contribution in [https://github.com/qossmic/deptrac/pull/1120](https://github.com/qossmic/deptrac/pull/1120) - [@​gusdeboer](https://github.com/gusdeboer) made their first contribution in [https://github.com/qossmic/deptrac/pull/1140](https://github.com/qossmic/deptrac/pull/1140) - [@​rubenrubiob](https://github.com/rubenrubiob) made their first contribution in [https://github.com/qossmic/deptrac/pull/1162](https://github.com/qossmic/deptrac/pull/1162) - [@​jdreesen](https://github.com/jdreesen) made their first contribution in [https://github.com/qossmic/deptrac/pull/1281](https://github.com/qossmic/deptrac/pull/1281) - [@​alexander-schranz](https://github.com/alexander-schranz) made their first contribution in [https://github.com/qossmic/deptrac/pull/1302](https://github.com/qossmic/deptrac/pull/1302) - [@​that-guy-iain](https://github.com/that-guy-iain) made their first contribution in [https://github.com/qossmic/deptrac/pull/1325](https://github.com/qossmic/deptrac/pull/1325) - [@​benr77](https://github.com/benr77) made their first contribution in [https://github.com/qossmic/deptrac/pull/1342](https://github.com/qossmic/deptrac/pull/1342) **Full Changelog**: qossmic/deptrac@1.0.2...2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/aggregate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Ref #1007