Composer collector exception when package does not exist #1279

maciejkosiarski · 2023-10-06T21:24:03Z

Throw InvalidCollectorDefinitionException if ComposerCollector could not locate a package

…not locate a package

patrickkusebauch

I have a small refactoring request to make sure that we do not intertwine things that do not need to be intertwined and therefore introduce assumptions that were not there before.

After all, that's what deptrac is for in the first place. It would not look good on us if we didn't follow the same rules we are helping others to follow. 😄

patrickkusebauch · 2023-10-06T21:52:51Z

src/Core/Layer/Collector/ComposerFilesParser.php

     */
    public function autoloadableNamespacesForRequirements(array $requirements, bool $includeDev): array
    {
        $namespaces = [[]];

        foreach ($requirements as $package) {
+            if (!array_key_exists($package, $this->lockedPackages)) {
+                throw InvalidCollectorDefinitionException::invalidCollectorConfiguration(sprintf('ComposerCollector got a package that doesn\'t exist: "%s"', $package));


You are referencing ComposerCollector inside this class ComposerFilesParser. The parser should be oblivious to how/by whom it is used.

You could instead just throw a generic RuntimeException and rethrow it as InvalidCollectorDefinitionException in the ComposerCollector.

patrickkusebauch

👍 LGTM

patrickkusebauch · 2023-10-06T22:20:35Z

Can you also add:

Fixes: #1230

to the PR description for cross reference?

maciejkosiarski · 2023-10-06T22:25:00Z

sure, did

gennadigennadigennadi · 2023-10-13T09:17:48Z

@maciejkosiarski thank you very much.

Throw InvalidCollectorDefinitionException if ComposerCollector could …

0ff745f

…not locate a package

maciejkosiarski mentioned this pull request Oct 6, 2023

Composer collector exception when package does not exist #1230

Closed

Fix phpcsfixer and phpstan analysis

ad0c248

patrickkusebauch suggested changes Oct 6, 2023

View reviewed changes

patrickkusebauch assigned maciejkosiarski Oct 6, 2023

Refactor exception throw in ComposerFilesParser

2d7da01

patrickkusebauch approved these changes Oct 6, 2023

View reviewed changes

maciejkosiarski changed the title ~~Composer collector exception when package does not exist~~ Composer collector exception when package does not exist Oct 6, 2023

gennadigennadigennadi merged commit 2f202c4 into qossmic:main Oct 13, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Composer collector exception when package does not exist #1279

Composer collector exception when package does not exist #1279

maciejkosiarski commented Oct 6, 2023 •

edited

Loading

patrickkusebauch left a comment

patrickkusebauch Oct 6, 2023

patrickkusebauch left a comment

patrickkusebauch commented Oct 6, 2023 •

edited

Loading

maciejkosiarski commented Oct 6, 2023

gennadigennadigennadi commented Oct 13, 2023

Composer collector exception when package does not exist #1279

Composer collector exception when package does not exist #1279

Conversation

maciejkosiarski commented Oct 6, 2023 • edited Loading

patrickkusebauch left a comment

Choose a reason for hiding this comment

patrickkusebauch Oct 6, 2023

Choose a reason for hiding this comment

patrickkusebauch left a comment

Choose a reason for hiding this comment

patrickkusebauch commented Oct 6, 2023 • edited Loading

maciejkosiarski commented Oct 6, 2023

gennadigennadigennadi commented Oct 13, 2023

maciejkosiarski commented Oct 6, 2023 •

edited

Loading

patrickkusebauch commented Oct 6, 2023 •

edited

Loading