-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed self updater and extended installation documentation #177
Conversation
i am 👎 because:
are there any pros? i would prefer providing a docker image. feel free to overvote me. |
I personally feel like Deptrac is unnecessarily too opinionated about the way it is being installed, cf. the discussion about being installed as a Composer package. That said, I agree with the current state of phive (as much as I appreciate the tool). So whilst I agree with adding an installation entry for it, I wouldn't put it as "recommended".
@timglabisch I don't know if your comment was about the wording, but there is no security issue per se. It means your PHAR is not signed with a GPG key (as an artefact, not using the PHAR built-in signing feature which is useless) but it is downloading it over HTTPS still which is pretty much the only think you can do at that point.
Side note, you can try |
👍
thanks for clarifying that. |
83fdb31
to
3320344
Compare
3320344
to
2d2a8a7
Compare
I removed the recommendation for phive. Feel free to review again :) |
i would prefer to keep the self-update until we've something better. |
I think we should switch to tagged versions as we could easily updating dependencies and refactoring code. Using the latest master build for self updating would break people's pipelines. Yes, I'm using deptrac in my pipelines! |
2d2a8a7
to
d352f01
Compare
The self-updating mechanism will be replaced by #185 which will be available with the upcoming release. |
Closes #173