Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC: track uncovered dependencies #266

Merged
merged 1 commit into from
Nov 20, 2019
Merged

POC: track uncovered dependencies #266

merged 1 commit into from
Nov 20, 2019

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Sep 20, 2019 •
edited
Loading

relates to #231

@smoench smoench mentioned this pull request Sep 20, 2019
Closed
@smoench smoench added this to the 0.6 milestone Sep 20, 2019
@smoench smoench force-pushed the track-uncovered-dependencies branch 2 times, most recently from c52cf99 to 4c6942d Compare September 24, 2019 08:03
@smoench smoench marked this pull request as ready for review September 24, 2019 08:09
This was referenced Oct 10, 2019
Closed
Closed
@timglabisch
Copy link
Collaborator

can you add some benchmarks, especially memory consumption?

@timglabisch
Copy link
Collaborator

generally a good pull request. we have to be careful with the performance (and mem.) but I'm optimistic

@smoench
Copy link
Contributor Author

smoench commented Oct 11, 2019 •
edited
Loading

With cache enabled: https://blackfire.io/profiles/compare/94c9ef0a-48cb-40d6-88f2-f16486c913d4/graph

@timglabisch
Copy link
Collaborator

With cache enabled: https://blackfire.io/profiles/compare/94c9ef0a-48cb-40d6-88f2-f16486c913d4/graph

can you add some context? can you test it on a large project? For example the entire symfony framework.

@smoench
Copy link
Contributor Author

smoench commented Oct 14, 2019

With cache enabled: https://blackfire.io/profiles/compare/94c9ef0a-48cb-40d6-88f2-f16486c913d4/graph

can you add some context? can you test it on a large project? For example the entire symfony framework.

I'm using examples/symfony_depfile.yml with the lastest symfony master.

@smoench smoench force-pushed the track-uncovered-dependencies branch 3 times, most recently from 6e59919 to 60a69af Compare October 14, 2019 13:23
@jakzal
Copy link

jakzal commented Oct 18, 2019

I tried testing it on one of my projects. Output is different. No errors or warnings are reported, but "0 Violations" is displayed in red.

Here's the latest deptrac vs this branch:

image

@smoench smoench modified the milestones: 0.6, 0.7 Oct 18, 2019
@smoench smoench force-pushed the track-uncovered-dependencies branch from 60a69af to 6e6ab65 Compare October 25, 2019 14:50
@smoench
Copy link
Contributor Author

smoench commented Oct 25, 2019

I adjusted the report as followed:
image
image

@smoench smoench force-pushed the track-uncovered-dependencies branch 2 times, most recently from 6bd4c0f to 86a4cf9 Compare October 28, 2019 15:56
@smoench smoench force-pushed the track-uncovered-dependencies branch from 86a4cf9 to c099d55 Compare November 20, 2019 17:55
@smoench
Copy link
Contributor Author

smoench commented Nov 20, 2019

This PR is collecting uncovered dependencies and outputs them. But doesn't report them as a violation nor change the exit code. It is a good base for such behavior. I will merge this PR now, so someone could take over and implement those behaviors.

@smoench smoench merged commit 27270b6 into master Nov 20, 2019
@smoench smoench deleted the track-uncovered-dependencies branch November 20, 2019 18:23
@jschaedl jschaedl removed their request for review March 4, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timglabisch timglabisch timglabisch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@smoench @timglabisch @jakzal