-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag --fail-on-uncovered (closes #306) #307
Conversation
@hugochinchilla Thank you, nice idea! Currently internal php classes are also blamed as uncovered. Need to fix this first. |
For me this is not a stopper as I have defined a layer named Language where I define all the internal classes to keep uncovered cases at zero. This is an example of what I do:
|
@smoench I have updated the PR to include new logic to not blame php internal classes as uncovered. There are unit tests for this feature. I still can't make a test for the |
@hugochinchilla Thanks for try figuring out how to resolve internal class likes. I think the best idea would to resolve this in an other PR.
This file could be added in |
Thank you @hugochinchilla |
Here is a patch to allow failure if uncovered cases are found.
I could not find any test to cover the changes made to the command nor the Context object, if tests are mandatory please explain where should I fit a test for this use-case.