Support non annotated property type

[sasezaki]

fix #455

[smoench]

@sasezaki Good catch. LGTM

Is there anything left or need help with something?

[sasezaki]

@smoench
thanks for review.

Is there anything left or need help with something?

Just , it left Coding Standards CI Failed issue.

Files that were not fixed due to errors reported during linting before fixing:

1. /home/runner/work/deptrac/deptrac/tests/AstRunner/Resolver/fixtures/PropertyTypeDependency.php
   https://github.com/sensiolabs-de/deptrac/pull/456/checks?check_run_id=1753259847

Can I add this PropertyTypeDependency.php into .php_cs.dist exclude ?

[sasezaki]

Can I add this PropertyTypeDependency.php into .php_cs.dist exclude ?

I did try with notPath.

$finder = PhpCsFixer\Finder::create()
    ->in([__DIR__.'/config', __DIR__.'/src', __DIR__.'/tests'])
    ->exclude('Fixtures')
    ->notPath('tests/AstRunner/Resolver/fixtures/PropertyTypeDependency.php')
    ->append([__DIR__.'/deptrac.php']);

but Finder still does not exclude PropertyTypeDependency.php file... 😢

[smoench]

Can you try to place your fixture file in the directory Fixtures (with a capital F). With the existing ->exclude('Fixtures') in .php_cs.dist your fixture file should be excluded.

[sasezaki]

@smoench
Shall I rename tests/AstRunner/Resolver/fixtures to tests/AstRunner/Resolver/Fixtures ?
or put PropertyTypeDependency.php into new Fixtures directory ?

[smoench]

That would be awesome but it's up to you. The rename would cause other test case adjustments. Lets try put PropertyTypeDependency.php into new Fixtures directory first if it's working you can try the rename.

[sasezaki]

@smoench
thank you for advice.
I did rename fixtures to Fixtures.

[smoench]

Thank you @sasezaki! Good job!