-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support php 8.1 #681
Conversation
@@ -17,7 +17,7 @@ | |||
} | |||
], | |||
"require": { | |||
"php": "^7.4.0 || 8.0.*", | |||
"php": "^7.4.0 || 8.0.* || 8.1.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you prefer instead
"php": "^7.4.0 || 8.0.* || 8.1.*", | |
"php": "^7.4.0 || ^8.0.0", |
|
Thanks a lot. |
@dbrumann looks like ci is failing at the moment 😢
|
Yes, I forgot to run the tests first. Not a big deal, though. We can allow PHP 8.1 to fail for now and then fix the issues. I will have a look at it later. |
Almost good in #685 except 2 things:
|
This is my 1st contribution to this project so I'm no sure I'm doing right: