-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid JS Output Formatter #948
Conversation
I think it is somewhat better as an extension. That's why https://github.com/Dance-Engineer/deptrac-awesome/blob/main/src/OutputFormatters/MermaidJsFormatter.php exists |
@patrickkusebauch I think it's fine to have this formatter in the core. I would like to replace some of the static images in the docs with the the MermaidJS-output at some point. I also have some vague ideas for features around this, e.g. extracting layers and rules from a diagram and then turning it into a depfile-template with basic formatters based on the names. |
e85632e
to
c7a689f
Compare
@jan-simbera The current implementation does not color a violations graph red, right? |
No, it only displays the results. No colored graph yet. Is it still considered to be added? Should I implement that additional? @gennadigennadigennadi |
Yes, it would be nice to have the same featureset as the graphiz-image has. @jan-simbera I don't know how someone would use the current output of the formatter, it gets dump straight into the stdout. Therefor I'm asking my self, if we should also use the And could you also implement a test, that verifies the current output-format? |
0c667aa
to
8e9e6e2
Compare
f76c87b
to
eccacb3
Compare
tests/Supportive/OutputFormatter/MermaidJSOutputFormatterTest.php
Outdated
Show resolved
Hide resolved
@jan-simbera Im okay with merging this branch, but would you also be willing to work on the php-config of the mermaidjs-formatter? |
Yeah, should I create a new MR, or should I add it to this one? |
What's the status of this PR? |
Documentation pending, small changes pending, I could get to finish this next week. |
Please update the git origin for development to https://github.com/qossmic/deptrac-src and reopen the PR. |
The basic implementation of the MermaidJS formatter.