Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outline-numbering.qml #252

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Update outline-numbering.qml #252

merged 2 commits into from
Dec 20, 2024

Conversation

DutchPete
Copy link
Contributor

Fixed numbering that was incorrect for deeper level headings.

Fixed numbering that was incorrect for deeper level headings.
@pbek
Copy link
Member

pbek commented Dec 18, 2024

You are changing almost every line of code in that pull request. I guess @Jerksen would need to review those changes.
And don't forget about the version number bump, https://github.com/qownnotes/scripts?tab=readme-ov-file#editing-an-existing-script-in-the-github-web-interface.

@pbek pbek added the wip Work in progress label Dec 18, 2024
@DutchPete
Copy link
Contributor Author

@Jerksen wrote that code 4 years ago, and since I originally pointed out the bug in the issues list he has not replied, so I guess he has abandoned the script.

So, what does that mean in practice for the revised script I submitted?

@pbek
Copy link
Member

pbek commented Dec 18, 2024

Ok, you didn't mention #248 here.
So please just bump the version and maybe also add yourself as maintainer of the script.

@DutchPete
Copy link
Contributor Author

Remember, I don't know anything about this stuff, so you'll get basic questions.

How do I bump the number? Please give me a link to the Github page to do that.

@pbek
Copy link
Member

pbek commented Dec 18, 2024

You are doing good. 😊
I mentioned the version number in #250 (comment).

@pbek
Copy link
Member

pbek commented Dec 18, 2024

But since you already have two open pull requests, be sure you are doing the commit to change the version in your patch-2 branch! That's here: https://github.com/DutchPete/scripts/tree/patch-2

@pbek pbek marked this pull request as draft December 19, 2024 06:20
@DutchPete
Copy link
Contributor Author

I assume the ball is in your court now: approval.

@pbek
Copy link
Member

pbek commented Dec 19, 2024

Approval of what?

@DutchPete
Copy link
Contributor Author

This, as shown above:

image

@pbek
Copy link
Member

pbek commented Dec 19, 2024

But you are not done yet, see #252 (comment).

@DutchPete
Copy link
Contributor Author

DutchPete commented Dec 20, 2024

So, please provide a link to the page where I can bump the version number. I suppose that is the only thing that still needs to be done.
Note: I am asking basic questions because I am completely unfamiliar with this. So, please answer questions as if I am a 5-year old.

@pbek
Copy link
Member

pbek commented Dec 20, 2024

The version number is always in the info.json next to the script.
In this case: https://github.com/DutchPete/scripts/blob/patch-2/outline-numbering/info.json#L7

Changed version number from 1.0.0 to 1.0.1
@DutchPete
Copy link
Contributor Author

I upped the version number and committed the change.

@pbek pbek marked this pull request as ready for review December 20, 2024 10:26
@pbek pbek merged commit cb7c0e3 into qownnotes:master Dec 20, 2024
@DutchPete
Copy link
Contributor Author

So, what is the next step with the PR being a WIP?

252-PR-wip

@pbek pbek removed the wip Work in progress label Dec 20, 2024
@pbek
Copy link
Member

pbek commented Dec 20, 2024

None. The PR was already merged.

@DutchPete DutchPete deleted the patch-2 branch December 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants