-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outline-numbering.qml #252
Conversation
Fixed numbering that was incorrect for deeper level headings.
You are changing almost every line of code in that pull request. I guess @Jerksen would need to review those changes. |
@Jerksen wrote that code 4 years ago, and since I originally pointed out the bug in the issues list he has not replied, so I guess he has abandoned the script. So, what does that mean in practice for the revised script I submitted? |
Ok, you didn't mention #248 here. |
Remember, I don't know anything about this stuff, so you'll get basic questions. How do I bump the number? Please give me a link to the Github page to do that. |
You are doing good. 😊 |
But since you already have two open pull requests, be sure you are doing the commit to change the version in your |
I assume the ball is in your court now: approval. |
Approval of what? |
But you are not done yet, see #252 (comment). |
So, please provide a link to the page where I can bump the version number. I suppose that is the only thing that still needs to be done. |
The version number is always in the |
Changed version number from 1.0.0 to 1.0.1
I upped the version number and committed the change. |
None. The PR was already merged. |
Fixed numbering that was incorrect for deeper level headings.