-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed TreeBuilder::root() symfony 4.3 deprecation #21
Conversation
The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "qp_woohoolabs_yin" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead
Hello @Doqnach 👋 , Since So we need to bump the major version and specify in What do you think ? |
For example:
and then fix this behaviour with next major version, dropping support for older |
Perfect, fine by me :) |
I will try to update the PR soon [tm] |
Updated the PR with the above suggested change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated thank you !
We are taking advantage of bumping to a major version to remove deprecation support. From version 5.5 of sensio/framework-extra-bundle the Symfony Config component has a minimal version of 4.3. Which means `getRootNode()` function is available. Related to #21.
We are taking advantage of bumping to a major version to remove deprecation support. From version 5.5 of sensio/framework-extra-bundle the Symfony Config component has a minimal version of 4.3. Which means `getRootNode()` function is available. Related to #21.
The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "qp_woohoolabs_yin" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead