Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QassaDevelopers
Copy link

I have update the composer file and Dockerfile to support PHP 8. The make test did succeed, so there should be no breaking changes.

Not sure how to handle the Dockerfile though, perhaps multiple stages can be added (i.e. one for php7.1 and one for php8)? The make build command could be passed the PHP version to build? Feedback is welcome regarding that.

It would be very nice if this could be merged, so we can at least use this package with PHP 8.

@fractalzombie
Copy link

This is so strange to see that PR is created more that 1 year ago, why did these people are making libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants