Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add includeStyleProperties option #63

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

aeharding
Copy link
Contributor

Description

Please see for details:

In this PR:

  • users can now manually specify which style properties are included

This commit is applied from bubkoo/html-to-image#436

Additional context

No


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

* the full list of computedStyle properties can be cached

This commit is applied from bubkoo/html-to-image#436
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modern-screenshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 3:05am

@qq15725 qq15725 merged commit 6f24f17 into qq15725:main Dec 5, 2023
4 checks passed
@aeharding aeharding deleted the include-style branch December 5, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants