Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const validator returns wrong message #34

Closed
stepro opened this issue Jan 15, 2019 · 2 comments · Fixed by #35
Closed

Const validator returns wrong message #34

stepro opened this issue Jan 15, 2019 · 2 comments · Fixed by #35
Assignees
@b5
Labels
bug Something isn't working

Comments

@stepro
Copy link

stepro commented Jan 15, 2019

Given a schema like

"const": "a value"

and a JSON document like

"a different value"

The error message is must equal "a different value" instead of must equal "a value".

Problem is at keywords.go:217.
@b5 b5 added the bug Something isn't working label Jan 21, 2019
b5 added a commit that referenced this issue Jan 21, 2019
@b5
fix(const error): error reports what const must equal instead of supp…
9b9427b 
…lied value

closes #34
@b5 b5 mentioned this issue Jan 21, 2019
Merged
@ghost ghost assigned b5 Jan 21, 2019
@ghost ghost added the in progress label Jan 21, 2019
b5 added a commit that referenced this issue Jan 21, 2019
@b5
test(ValError): add test to check validation error messages
6dda53c 
confirms #34 is fixed, puts fourth a pattern for testing other error messages. I've moved ValError into it's own file for added clarity.
@b5 b5 closed this as completed in #35 Jan 21, 2019
@ghost ghost removed the in progress label Jan 21, 2019
@stepro
Copy link
Author

stepro commented Jan 21, 2019

Thanks @b5!

@b5
Copy link
Member

b5 commented Jan 21, 2019

No problem. Thanks for filing such an easy-to-follow issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b5 b5

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(const error): error reports what const must equal instead of supplied value qri-io/jsonschema
2 participants
@stepro @b5