Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to go-ipfs 0.5.0 #24

Merged
merged 1 commit into from
May 15, 2020
Merged

chore(deps): upgrade to go-ipfs 0.5.0 #24

merged 1 commit into from
May 15, 2020

Conversation

b5
Copy link
Member

@b5 b5 commented Apr 9, 2020

part of a set of PRs for qri-io/qri#1225

This adds a Migrate function for ipfs filestore that does repo migrations. The migration binary itself is separately downloaded, which keeps import overhead small.

@b5 b5 self-assigned this Apr 9, 2020
@b5 b5 added the chore label Apr 9, 2020
@b5 b5 requested a review from ramfox April 29, 2020 12:34
@b5 b5 marked this pull request as ready for review April 29, 2020 12:36
@b5
Copy link
Member Author

b5 commented Apr 29, 2020

@ramfox I need to clean up a commented-out test file, but this should be ready to start review. Fairly straightforward.

jobs:
build:
working_directory: /go/src/github.com/qri-io/qfs
docker:
- image: circleci/golang:1.12
- image: circleci/golang:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we really do latest, typically we try to stick to 1.13

@b5 b5 mentioned this pull request Apr 29, 2020
8 tasks
Copy link
Contributor

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b5 b5 merged commit 3b8abb5 into master May 15, 2020
@b5 b5 deleted the chore_deps branch May 15, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants