bring startf inline #785
Merged
bring startf inline #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
startf relies on qri. using go modules it's a major antipattern to depend on test files across repositories (we could get away with this when we had GOPATH, not so much now). Let's just bite the bullet & move this package inline
b5
added
docs
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oooook, gomodules is forcing this issue on our startf separation anxiety. startf relies on qri. When using go modules it's a major antipattern to depend on test files across repositories, which is happening here. We could get away with this when we had GOPATH, not so much now, but I think the ultimate "right" answer is to have common test data in a common repository.
Let's just bite the bullet & move this package inline