Skip to content

Commit

Permalink
Android: Add QEXPECT_FAIL to flaky tst_android testFullScreenDimensions
Browse files Browse the repository at this point in the history
This patch temporarily adds QEXPECT_FAIL to testFullScreenDimensions
test on Android 15.

Reason for this is that the testFullScreenDimensions from tst_Android
had been flaky on Android 15 and recently it had started to fail
continuously. QEXPECT_FAIL keeps CI status same between Android 14 and
15, before this test case is fixed.

Task-number: QTBUG-131338
Pick-to: 6.8 6.5
Change-Id: I32a610283b5b9f1502251d1dcc940897b389f092
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
  • Loading branch information
Rami Potinkara committed Nov 21, 2024
1 parent fe672c3 commit 5a3867a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/auto/corelib/platform/android/tst_android.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,10 @@ void tst_Android::testFullScreenDimensions()
QTRY_COMPARE(screen->availableGeometry().width(), expectedWidth);

int expectedHeight = appSize.getField<jint>("y") - insetsHeight;
if (QNativeInterface::QAndroidApplication::sdkVersion() == __ANDROID_API_V__){
QEXPECT_FAIL("",
"Geometry height mismatch on Android 15. Reported: QTBUG-131338", Continue);
}
QTRY_COMPARE(screen->availableGeometry().height(), expectedHeight);

QTRY_COMPARE(screen->geometry().width(), realSize.getField<jint>("x"));
Expand Down

0 comments on commit 5a3867a

Please sign in to comment.