Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woocommerce Module Deprecated Function #686

Closed
KostasKapa opened this issue May 14, 2019 · 3 comments
Closed

Woocommerce Module Deprecated Function #686

KostasKapa opened this issue May 14, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@KostasKapa
Copy link

Notice: Το woocommerce_get_product_attributes is deprecated.
You have to change line 69 in qwc-front.php
add_filter( 'woocommerce_get_product_attributes', 'qwc_get_product_attributes', 5 );
with
add_filter( 'woocommerce_product_get_attributes', 'qwc_get_product_attributes', 5 );

@herrvigg
Copy link
Collaborator

herrvigg commented May 15, 2019

Thanks! But... this change is very, very old!! They deprecated it in WC 3.0.0 if the version is correct in class-wc-deprecated-filter-hooks. According to their CHANGELOG this sends us back to... 2017! This surprises me since many people have used this meanwhile.

Could this explain some of the current issues? Maybe! I'd need some WC users to help me find the related issues, for example looking through: https://github.com/qtranslate/qtranslate-xt/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+woocommerce

I also found that woocommerce_order_tax_totals was replaced with woocommerce_order_get_tax_totals but that's more of a minor thing.

I'm also pretty sure there are many filters that can be added to the module for better support but i can't really say what matters. Would be good to have more developers using WC involved.

@herrvigg herrvigg added the help wanted Extra attention is needed label May 15, 2019
herrvigg added a commit that referenced this issue May 15, 2019
Deprecated in WC 3.0.0 (2017-04-04!)
- woocommerce_get_product_attributes
- woocommerce_order_tax_totals
@herrvigg
Copy link
Collaborator

Fixed in master.
Please help to review existing tickets (see link above), this may close some issues.

@herrvigg
Copy link
Collaborator

herrvigg commented Jul 3, 2019

I found another deprecated filter:
woocommerce_add_cart_hash replaced with woocommerce_cart_hash (since WC 3.6.0).

These 3 fixes are included in the last release of qT-XT version 3.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants