QTS: remove slug fields for WC attributes add/edit page #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrvigg
requested changes
May 9, 2022
There was a problem hiding this comment.
-
I can't find the product attributes in the slugs settings.
-
Please break the patch in two, I'd prefer to have all the l10n changes in a separate PR because they impact more than slugs and it will be easier to track in the git history.
For example to save the changes:
git checkout -b update-l10n
git checkout wc_attibute_add_edit_fix
git reset HEAD~
| <td> | ||
| <?php | ||
| //TODO: link destination should not be hardcoded here, but currently $options_uri property is private in QTX_Admin_Settings class (base options page) and module id is hardcoded independently from module definitions in QTX_Admin_Module class (module href). | ||
| echo sprintf( "<p>" . __( 'Multilanguage slugs can be set up in <a href="%s">slugs module settings</a>', 'qtranslate' ) . "</p>", admin_url( 'options-general.php?page=qtranslate-xt#slugs' ) ); |
There was a problem hiding this comment.
Maybe i'm missing something, but I don't find the product attributes in the settings.
I can find the product categories and tags, but not the attributes 😢
There was a problem hiding this comment.
You need this check enabled in your test attribute, otherwise there is no archive page and no slug needed.
Slugs fields from WC attribute add/edit admin pages are replaced with the link to the relevant existing slugs module settings page.
spleen1981
force-pushed
the
wc_attibute_add_edit_fix
branch
from
c18597c to
9f4e5fb
Compare
herrvigg
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace slug fields from WC attribute add/edit admin pages with the link to the relevant existing slugs module settings page.