Replace slugs qts_page_request cache with transient
#1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WP cache is not appropriated for very short term storage. Moreover a wrong value could have been stored between different requests. Replace the cache call with a transient expiring after 30s. Delete the transient right after reading it. Rename it to `qtranslate_slugs_matched_page`.
herrvigg
force-pushed
the
slugs-transient-match
branch
from
d6b24ba to
621a034
Compare
herrvigg
commented
Jun 6, 2022
| if ( ! $page ) { | ||
| return $query; | ||
| } | ||
| $id = $page->ID; | ||
| $cache_array = array( $page ); | ||
| update_post_caches( $cache_array, 'page' ); // caching query :) | ||
| wp_cache_delete( 'qts_page_request' ); | ||
| update_post_caches( $cache_array, 'page' ); |
There was a problem hiding this comment.
Not related to this patch, but I'm not sure about this update_post_caches and all similar updates in QTS.
There was a problem hiding this comment.
Not sure if it's really needed, also because we are not modifying the post objects here. But I don't think it has anything to do with the caching query :) comment btw.
This is calling eventually wp_cache_add_multiple, so I think is not updating anything most of the time (it will only update if those keys do not exist already).
We may just add a comment to double check later or remove the calls now...
spleen1981
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WP cache is not appropriated for very short term storage.
Moreover a wrong value could have been stored between different requests.
Replace the cache call with a transient expiring after 30s.
Delete the transient right after reading it.
Rename it to
qtranslate_slugs_matched_page.