Delete admin translator, tidy up front interface #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admin interface was meant to translate admin items specifically, like multilingual terms, but it is not used internally in practice. Delete `QTX_Translator_Admin` class and `WP_Translator_Admin` interface. Delete the `multilingual_term` hook that is specific to qTranslate. If some users were using that hook, which is very unlikely, they can still call `qtranxf_get_terms_joined` directly. Polish the base interface and translator that remains for front side. Rename `WP_Translator` to `QTX_Translator_Interface`. Redefine the flag constants properly, tidy up PHPDoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin interface was meant to translate admin items specifically, like multilingual terms, but it is not used internally in practice.
Delete
QTX_Translator_Adminclass andWP_Translator_Admininterface.Delete the
multilingual_termhook that is specific to qTranslate.If some users were using that hook, which is very unlikely, they can still call
qtranxf_get_terms_joineddirectly.Polish the base interface and translator that remains for front side. Rename
WP_TranslatortoQTX_Translator_Interface.Redefine the flag constants properly, tidy up PHPDoc.