FIX: Translate product name in WC order admin page #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing WooCommerce orders from the admin side, the name of the product ('item') wouldn't be translated properly.
|
OK thank you. I think this worked previously but the recent fixes such as #612 could introduce small regressions here. Good it can be handled with just a display hook. |
herrvigg
added
module: WC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing WooCommerce orders from the admin side, the name of the product ('item') wouldn't be translated properly.
Here's the issue in the admin (edit order) page:
(P.S. I agree as herrvigg said that the Woocommerce file doing all this in PHP is messy, and should be changed to JSON. That's an issue for another time...)