Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for connect features #30

Merged
merged 15 commits into from
Jul 21, 2023
Merged

Add support for connect features #30

merged 15 commits into from
Jul 21, 2023

Conversation

xxswingxx
Copy link
Contributor

The following resources where added:

  • Added support for accounts API (as Quaderno::Account)
  • Added support for tax rates API (as Quaderno::TaxRate)
  • Added support for tax jurisdictions API (as Quaderno::TaxJurisdiction)
  • Added support for tax codes API (as Quaderno::TaxCode)

Maintenance:

  • Phase out legacy Quaderno::Tax class in favour of Quaderno::TaxRate
  • Clean parameters sent in the create request
  • Relaxed httparty requirements
  • Detect and handle bad_request response codes

@xxswingxx xxswingxx requested review from polimorfico and a team July 20, 2023 10:18
@xxswingxx xxswingxx self-assigned this Jul 20, 2023
@xxswingxx xxswingxx marked this pull request as ready for review July 20, 2023 15:01
@xxswingxx xxswingxx merged commit b3f39dd into master Jul 21, 2023
2 checks passed
@xxswingxx xxswingxx deleted the connect-features branch July 21, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polimorfico polimorfico polimorfico approved these changes

Assignees

@xxswingxx xxswingxx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxswingxx @polimorfico