feat: add round away from zero and fix StringFixed issue #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
RoundAwayFromZero
RoundToInf
but I think people might mistakenly assume thatRoundToInf
is rounding to positive infinity. Renaming it toRoundAwayFromZero
provides more clarity and helps avoid confusionRoundHAZ
andRoundHTZ
. That's because short from of this method method isRoundAZ
which looks very similar toRoundHAZ
if we just glance. Also I feel like make it verbose will help reduce the cognitive complexity (no more mappingRoundAZ = Round Away From Zero
). It's also good to renameRoundHAZ
toRoundHalfAwayZero
so it's consistent and less complex but that change is beyond the scope of this PRStringFixed()
issue described in StringFixed fixed rounding does not work as expected for fixed numbers #23