Refactor/switch id3 functions with cml id3 functions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeYoungi
reviewed
Feb 6, 2024
felipeYoungi
reviewed
Feb 7, 2024
Signed-off-by: coatesjuan <juanco@qualabs.com>
hernanr99
approved these changes
Feb 27, 2024
coatesjuan
approved these changes
Feb 27, 2024
felipeYoungi
approved these changes
Feb 28, 2024
This reverts commit 57203a7.
tests/unit/demuxer/id3.ts
Outdated
There was a problem hiding this comment.
I wonder if we shouldn't just remove this file
There was a problem hiding this comment.
Agreed. Verify that utf8ArrayToStr isn't being used anywhere else in the code base, and if not, remove this file.
There was a problem hiding this comment.
Okay turns out this function is being used in:
- parseWebVTT function in
webvtt-parser.ts - parseSEIMessageFromNALu function in
mp4-tools.ts - parseIMSC1 function in
imsc1-ttml-parser.ts
Signed-off-by: Felipe Young <felipey@qualabs.com>
littlespex
reviewed
Feb 29, 2024
src/demux/id3.ts
Outdated
tests/unit/demuxer/id3.ts
Outdated
There was a problem hiding this comment.
Agreed. Verify that utf8ArrayToStr isn't being used anywhere else in the code base, and if not, remove this file.
Signed-off-by: Felipe Young <felipey@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: Felipe Young <felipey@qualabs.com>
felipeYoungi
approved these changes
Mar 4, 2024
Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com>
Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
…r-122.x chore(deps): update dependency chromedriver to v122.0.5
…r-122.x chore(deps): update dependency chromedriver to v122.0.6
fix after rebase
…pi-documenter-7.x chore(deps): update dependency @microsoft/api-documenter to v7.23.38
…pi-documenter-7.x chore(deps): update dependency @microsoft/api-documenter to v7.24.1
…eslint-monorepo chore(deps): update typescript-eslint monorepo to v7.3.0
…eslint-monorepo chore(deps): update typescript-eslint monorepo to v7.3.1
chore(deps): update babel monorepo to v7.24.1
chore(deps): update babel monorepo to v7.24.3
chore(deps): update dependency @types/chai to v4.3.13
chore(deps): update dependency @types/chai to v4.3.14
…pi-extractor-7.x chore(deps): update dependency @microsoft/api-extractor to v7.43.0
chore(deps): update dependency wrangler to v3.35.0
chore(deps): update dependency wrangler to v3.38.0
chore(deps): update dependency typescript to v5.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
What improvements to ID3 Parsing will this change include?
Why is this Pull Request needed?
The id3 utilities have been manually implemented in multiple player libraries. When bugs need to be fixed, or features added, then need to be done across all of these projects. The common media library provides a single place for these utilities to live and be maintained.
Also hls.js doesn't parse id3 APIC data and with this change it is going to be able to handle that data.
What assets have these changes been tested against?
We tested this changes using 2 assets:
https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_16x9/bipbop_16x9_variant.m3u8
https://test-streams.mux.dev/dai-discontinuity-deltatre/manifest.m3u8
https://stream-cdn-1.open.fm/OFM18/ngrp:standard/playlist.m3u8(APIC between songs).
What history and roadmap for the CML can you share(based on which player code and tested for which application use cases)?
We currently use Github milestones (same as hls.js), in combination with the project board. We only have a few features officially planned, so the roadmap isn't very big:
https://github.com/streaming-video-technology-alliance/common-media-library/milestones
Checklist