-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions integration #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure if this will cause a loop :-)
…wissrets into github-actions-integration
…wissrets into github-actions-integration
…ctions-integration
Looks like some of the docs/docs/html changes have made it into this branch. I/we will need to update theses back to the master representation, since these files should not change based on a PR. (only when release version tag gets set). |
jensstalder
commented
Jan 12, 2021
Just noticed that there is a docker-compose.yml file that sets-up the dotnet testing within a docker container. Intresting. |
koffeinfrei
reviewed
Jan 12, 2021
koffeinfrei
reviewed
Jan 12, 2021
koffeinfrei
reviewed
Jan 12, 2021
koffeinfrei
reviewed
Jan 12, 2021
Otherwise LGTM 👍 |
Since we are testing more simpler currently, by utilizing basic github actions and xml validations instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantic versioning
This PR is a Patch (bugfix, hotfix, without adding new stuff)
Generall things to consider
List of issues related to this PR
Problem description
Currently there are a couple of dependencies to dotnet and travis that can be replaced with github actions ever since it has been introduced. This would make things more accessible to web-developers by leveraging node.js instead which is already in use anyhow.
Desired Solution
Removal of Jenkins pipeline
Creating appropriate github actions
Rewrite tests with node.js