Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions integration #171

Merged
merged 27 commits into from
Jan 13, 2021
Merged

GitHub actions integration #171

merged 27 commits into from
Jan 13, 2021

Conversation

jensstalder
Copy link
Collaborator

Semantic versioning

This PR is a Patch (bugfix, hotfix, without adding new stuff)

Generall things to consider

  • I have read the CONTRIBUTING.md document.
  • If my change requires documentation, I added it already.
  • I have added tests to cover all my changes.
  • All new and existing tests pass.

List of issues related to this PR

Problem description
Currently there are a couple of dependencies to dotnet and travis that can be replaced with github actions ever since it has been introduced. This would make things more accessible to web-developers by leveraging node.js instead which is already in use anyhow.

Desired Solution

Removal of Jenkins pipeline
Creating appropriate github actions
Rewrite tests with node.js

@jensstalder
Copy link
Collaborator Author

Looks like some of the docs/docs/html changes have made it into this branch. I/we will need to update theses back to the master representation, since these files should not change based on a PR. (only when release version tag gets set).

@jensstalder jensstalder added this to the 2.2.0 milestone Jan 12, 2021
package.json Outdated Show resolved Hide resolved
@jensstalder
Copy link
Collaborator Author

Just noticed that there is a docker-compose.yml file that sets-up the dotnet testing within a docker container. Intresting.

package.json Outdated Show resolved Hide resolved
@koffeinfrei
Copy link
Collaborator

  • package-lock.json is outdated.
  • Should we add an .nvmrc (or any other alternative you prefer) to lock the node version?

Otherwise LGTM 👍

@jensstalder jensstalder merged commit 3746feb into master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to github actions and pure Node.js linting
2 participants