Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for more flexible rental prices #196

Merged

Conversation

jensstalder
Copy link
Collaborator

This allows for

  • only specifying net
  • only specifying extra

This was previously not possible since gross was made required.

This PR is a Minor (non-breaking change, adds functionality or feature)

List of issues related to this PR

This allows for

* only specifying net
* only specifying extra

This was previously not possible since gross was made required.
@jensstalder
Copy link
Collaborator Author

Tried first with all elements as minOccurs="0" but that alloed for an empty <rent> tag. Now its a choice of possible sequences. I am a bit konfused as to why the order does not matter? I thought sequences require the order to be in the declared manor?

@jensstalder jensstalder added this to the 2.4.0 milestone Oct 22, 2021
@jensstalder jensstalder self-assigned this Oct 22, 2021
@jensstalder jensstalder added the Bug Broken functionality label Oct 22, 2021
@jensstalder jensstalder merged commit 76745a5 into qualipool:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a reason why gross is required?
1 participant