Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: co-non ambiguous issue but allows for empty <rent> #207

Merged
merged 8 commits into from
Feb 3, 2022

Conversation

jensstalder
Copy link
Collaborator

@jensstalder jensstalder commented Dec 17, 2021

This will fix the co-non ambiguous issue, but it will allow <rent> tag to be empty. Wich differs from <buy>. I did not find a good way to test for that. The previous change did work by using <sequences> as a work-around but caused the co-non ambiguous issue for some validators.

Either we allow for that discrepancy, (The XSD would look a bit nicer). Or we need to find some way of making the xmls fail that include empty <rend> tags. And for that matter should we also allow it for <buy> to be more consistent?

There is an unwritten rule that goes something like this:

Omitting a tag represents that there is "no info" and should be skipped when consuming, if there is existing data, leave it. This is useful for delivery systems that "enrich" data rather than dictating the entire state. Think PATCH vs PUT 😉
Sending an empty tag represents that the content is to be deleted if present.

Here it's just a bit difficult to manage since there is a wrapping <prices> tag already (which can be omitted).

Needs to be merged first
#206

Relates to
#204

@jensstalder jensstalder linked an issue Dec 17, 2021 that may be closed by this pull request
@jensstalder jensstalder self-assigned this Dec 17, 2021
@jensstalder jensstalder marked this pull request as draft December 17, 2021 08:21
@jensstalder
Copy link
Collaborator Author

jensstalder commented Dec 17, 2021

  • Should we also adjust <buy> to behave the same? (Is in the pr)
  • Is this considered breaking? Or even just a patch?
  • Is there a solution to keep it the same as it is (with not allowing empty <rent>, and still avoiding the cos-nonambig-fix problem.

@jensstalder jensstalder changed the title fix: Possible but allows for empty <rent> fix: co-non ambiguous issue but allows for empty <rent> Dec 17, 2021
@jensstalder jensstalder marked this pull request as ready for review December 17, 2021 14:13
@merrycoder
Copy link
Collaborator

  • Should we also adjust <buy> to behave the same? (Is in the pr)

IMO i'd say yes. Would be good be consistent.

  • Is this considered breaking? Or even just a patch?

Strictly speaking this is a breaking change.

@tilenseer tilenseer merged commit c64ef37 into qualipool:master Feb 3, 2022
@tilenseer tilenseer mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cos-nonambig validation issue
3 participants