fix: co-non ambiguous issue but allows for empty <rent> #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the co-non ambiguous issue, but it will allow
<rent>
tag to be empty. Wich differs from<buy>
. I did not find a good way to test for that. The previous change did work by using<sequences>
as a work-around but caused the co-non ambiguous issue for some validators.Either we allow for that discrepancy, (The XSD would look a bit nicer). Or we need to find some way of making the xmls fail that include empty
<rend>
tags. And for that matter should we also allow it for<buy>
to be more consistent?There is an unwritten rule that goes something like this:
Here it's just a bit difficult to manage since there is a wrapping
<prices>
tag already (which can be omitted).Needs to be merged first
#206
Relates to
#204