Skip to content

Commit

Permalink
Fix vignette building by using static vignettes
Browse files Browse the repository at this point in the history
CRAN submissions failed because the CRAN process could not build the vignettes, as we did not script the installation of the Python/spaCy/language model process.  The solution was to swtich to static vignettes (built locally) and include them using the R.rsp package.
  • Loading branch information
kbenoit committed Dec 15, 2018
1 parent b929211 commit 4074362
Show file tree
Hide file tree
Showing 8 changed files with 885 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
^Meta$
^doc$
^CRAN-RELEASE$
^docs$
^\.lintr$
Expand All @@ -12,7 +14,6 @@
^testenv
^spacyr/testenv
^env
^vignettes
^appveyor\.yml$
^tests/misc$
^cran-comments\.md$
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
Meta
doc
inst/doc
.Rproj.user
.Rhistory
Expand Down
11 changes: 6 additions & 5 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ Imports:
data.table,
reticulate (>= 1.6)
Suggests:
spelling,
rmarkdown,
testthat,
knitr,
quanteda
quanteda,
R.rsp,
rmarkdown,
spelling,
testthat
URL: https://spacyr.quanteda.io
Encoding: UTF-8
BugReports: https://github.com/quanteda/spacyr/issues
RoxygenNote: 6.1.1
Language: en-GB
VignetteBuilder: knitr
VignetteBuilder: R.rsp
2 changes: 0 additions & 2 deletions vignettes/.gitignore

This file was deleted.

Loading

0 comments on commit 4074362

Please sign in to comment.