STY: trailing comma, variable naming, imports

pyfolio/perf_attrib.py

@@ -161,7 +161,7 @@ def show_perf_attrib_stats(returns, positions, factor_returns,
         positions,
         factor_returns,
         factor_loadings,
-        pos_in_dollars=pos_in_dollars
+        pos_in_dollars=pos_in_dollars,
     )
 
     perf_attrib_stats = create_perf_attrib_stats(perf_attrib_data)
@@ -270,8 +270,8 @@ def plot_factor_contribution_to_perf(perf_attrib_data, ax=None):
     factors_and_specific = perf_attrib_data.drop(
         ['total_returns', 'common_returns'], axis='columns')
 
-    for s in factors_and_specific:
-        ax.plot(factors_and_specific[s])
+    for col in factors_and_specific:
+        ax.plot(factors_and_specific[col])
 
     ax.axhline(0, color='k')
     set_legend_location(ax)
@@ -304,8 +304,8 @@ def plot_risk_exposures(exposures, ax=None):
     if ax is None:
         ax = plt.gca()
 
-    for s in exposures:
-        ax.plot(exposures[s])
+    for col in exposures:
+        ax.plot(exposures[col])
 
     set_legend_location(ax)
     ax.set_ylabel('Factor exposures')

pyfolio/utils.py

@@ -17,7 +17,6 @@
 
 import warnings
 
-from cycler import cycler
 import numpy as np
 import pandas as pd
 from IPython.display import display
@@ -624,8 +623,7 @@ def set_legend_location(ax, autofmt_xdate=True):
     ax.legend(frameon=True, framealpha=0.5, loc='upper left',
               bbox_to_anchor=(1.05, 1))
 
-    color_cycle = cycler('color', COLORS)
-    ax.set_prop_cycle(color_cycle)
+    ax.set_prop_cycle('color', COLORS)
 
     if autofmt_xdate:
         ax.figure.autofmt_xdate()