Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too Many config files #439

Closed
WaylonWalker opened this issue Jul 21, 2020 · 3 comments
Closed

Too Many config files #439

WaylonWalker opened this issue Jul 21, 2020 · 3 comments
Assignees
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@WaylonWalker
Copy link
Contributor

WaylonWalker commented Jul 21, 2020

Description

Kedro implements its own proprietary .kedro.yml config file. This is great to have a place to configure the project, but these files can really add up. Other python libraries/tools, such as mypy and flake8, allow multiple config file options. They typically set up proprietary config file locations but also allow for generic options like setup.cfg or pyproject.toml to be used to consolidate tooling config in one place.

mypy config file docs
flake8 config file docs

Possible Implementation

setup.cfg

Follow suit of other libraries for config resolution. Look for kedro.yml then .kedro.yml, then look for a kedro key in setup.cfg, then look for a key in pyproject.toml

@WaylonWalker WaylonWalker added the Issue: Feature Request New feature or improvement to existing feature label Jul 21, 2020
@DmitriiDeriabinQB
Copy link
Contributor

Hi @WaylonWalker, thanks for raising this! This is a valid point, I will add it to the technical discussion.

@andrii-ivaniuk andrii-ivaniuk self-assigned this Aug 20, 2020
@andrii-ivaniuk
Copy link
Contributor

Hi @WaylonWalker,
Thanks for raising this issue. Kedro was extended and now it is possible to configure it via pyproject.toml. All the Kedro-related parameters should be provided under [tool.kedro] section.

In general, Kedro will try to read .kedro.yml file. If it doesn't exist, it will read pyproject.toml.

These changes are available in 69c1d1c commit.

@WaylonWalker
Copy link
Contributor Author

Awesome!! Can't wait to see 16.5 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Development

No branches or pull requests

3 participants