Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mlflow init work when configuration is in pyproject.toml #96

Closed
Galileo-Galilei opened this issue Oct 18, 2020 · 2 comments · Fixed by #94
Closed

Make mlflow init work when configuration is in pyproject.toml #96

Galileo-Galilei opened this issue Oct 18, 2020 · 2 comments · Fixed by #94
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Oct 18, 2020

Description

Since 0.16.5, kedro project can now be configured with a pyproject.toml config file instead of a .kedro.yml at the root of the projects. This breaks the kedro mlflow init command which is only compatible with .kedro.yml configuration file.

Context

We should remove the _get_project_globals util function in kedromlflow and use kedro.framework.context import get_static_project_data as suggested in #86. Beware: this will break retrocompatibilty and work only with kedro>=0.16.5

Steps to Reproduce

Launch kedro mlflow init with no .kedro.yml config file in your project but a valid pyproject.toml.

Expected Result

The mlflow.yml file should be created

Actual Result

An error is raised.

@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Oct 18, 2020
@Galileo-Galilei Galileo-Galilei changed the title Make mlflow init work when configuration is in pyporject.toml Make mlflow init work when configuration is in pyproject.toml Oct 18, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.5.0 milestone Oct 18, 2020
@takikadiri
Copy link
Collaborator

Well spoted ! We can already solve this, by bundling kedro's get_static_project_data inside kedro_mlflow as long as we keep kedro < 0.16.5 retrocompatibility. We can switch then to kedro.framework.context import get_static_project_data when we drop this compatibility in the futur. I can add it to Migrate 0.16.5 pull request

@Galileo-Galilei
Copy link
Owner Author

Ok let's do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants