FIX #62 - Migrate to 0.16.5 #94
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
- Coverage 97.45% 97.39% -0.07%
===========================================
Files 32 32
Lines 1258 1227 -31
===========================================
- Hits 1226 1195 -31
Misses 32 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
It's almost ok, just a a few missing updates:
- for what it's worth, remove this line in flake8 config:
Line 6 in e8f9f09
- update documentation accordingly:
- explain what is necessary to set hooks up in two lines in the hellow orld example, or add a link to the more advanced section: https://github.com/Galileo-Galilei/kedro-mlflow/blob/develop/docs/source/02_hello_world_example/02_first_steps.md
- Modify this section to explain how to set hooks up manually: https://github.com/Galileo-Galilei/kedro-mlflow/blob/develop/docs/source/03_tutorial/02_setup.md. You very likely need a section for
kedro>=0.16.0, <0.16.4(withrun.py), and one forkedro>=016.5with hooks.py). It can be very short as long as it is clear.
takikadiri
force-pushed
the
feature/kedro-0.16.5
branch
from
281dfa5
to
084a8f5
Compare
kedro_mlflow/utils.py
Outdated
| kedro_version=KEDRO_VERSION, | ||
| ) | ||
|
|
||
|
|
||
| def _get_project_globals_with_pyproject( |
There was a problem hiding this comment.
Why don't you use get_static_project_data (from kedro/framework/context/context)? The goal was to avoid redefining thing by ourselves and to default to their implentation. If we can't do this for a specific reason this adds a lot of maintenance issues...
We may just make a try import get_static_project_data, or a check on the kedro version>=0.16.5.
There was a problem hiding this comment.
I've temporarily copy paste it, waiting for kedro < 0.16.5 support drop. But yes, it's more cleaner to just try import kedro's get_static_project_data and import our _get_project globals as get_static_project_data
There was a problem hiding this comment.
This breaks the test coverage (because only one of the 2 lines of the sucessful import are imported, and the other conditional import is never called in a test). Add "# pragma: no cover" on the lines 15-16, and everything's ok !
takikadiri
force-pushed
the
feature/kedro-0.16.5
branch
from
084a8f5
to
6420f5d
Compare
kedro_mlflow/framework/cli/cli.py
Outdated
| except ImportError: | ||
| from kedro_mlflow.utils import _get_project_globals as get_static_project_data |
There was a problem hiding this comment.
Add "# pragma: no cover" to avoid decreasing coverage.
takikadiri
force-pushed
the
feature/kedro-0.16.5
branch
from
6420f5d
to
33e341e
Compare
closes #62 #96
Description
This PR enable the support of kedro 0.16.5
Development notes
The major changes concern the remove of
run.pymanagment. That include,run.pyfrom templaterun.pyrelated code from thenclirun.pyrelated tests fromtemplateandcliChecklist
CHANGELOG.mdfile. Please respect Keep a Changelog guidelines.Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.