Pass shell script arguments without splitting (#4629)

Unquoted $@ splits shell script arguments on whitespace.
Use the "$@" form to pass arguments exactly as received.

check/all

@@ -38,7 +38,7 @@ cd "$(git rev-parse --show-toplevel)"
 apply_arg=""
 only_changed=0
 rev=""
-for arg in $@; do
+for arg in "$@"; do
     if [[ "${arg}" == "--only-changed-files" ]]; then
         only_changed=1
     elif [[ "${arg}" == "--apply-format-changes" ]]; then

check/asv_run

@@ -12,4 +12,4 @@ cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
 export ASV_PYTHONPATH="$(git rev-parse --show-toplevel)/examples"
-asv run $@
+asv run "$@"

check/doctest

@@ -19,4 +19,4 @@ cd "$(git rev-parse --show-toplevel)"
 
 source dev_tools/pypath
 
-python dev_tools/docs/run_doctest.py $@
+python dev_tools/docs/run_doctest.py "$@"

check/format-incremental

@@ -40,7 +40,7 @@ cd "$(git rev-parse --show-toplevel)"
 only_print=1
 only_changed=1
 rev=""
-for arg in $@; do
+for arg in "$@"; do
     if [[ "${arg}" == "--apply" ]]; then
         only_print=0
     elif [[ "${arg}" == "--all" ]]; then

check/mypy

@@ -12,7 +12,7 @@ cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
 config_file='mypy.ini'
-for arg in $@; do
+for arg in "$@"; do
     if [[ "${arg}" == "--next" ]]; then
         config_file='mypy-next.ini'
         shift
@@ -22,7 +22,7 @@ done
 CIRQ_PACKAGES=$(env PYTHONPATH=. python dev_tools/modules.py list --mode package-path)
 
 echo -e -n "\033[31m"
-mypy --config-file=dev_tools/conf/mypy.ini $@ $CIRQ_PACKAGES dev_tools examples
+mypy --config-file=dev_tools/conf/mypy.ini "$@" $CIRQ_PACKAGES dev_tools examples
 result=$?
 echo -e -n "\033[0m"
 

check/nbformat

@@ -15,7 +15,7 @@
 ################################################################################
 
 only_print=1
-for arg in $@; do
+for arg in "$@"; do
     if [[ "${arg}" == "--apply" ]]; then
         only_print=0
     else
@@ -52,4 +52,4 @@ elif (( only_print == 1 )); then
     exit 1
 else
     echo -e "\033[33mReformatted changed notebooks\033[0m."
-fi
+fi

check/npm

@@ -26,4 +26,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-npm --prefix 'cirq-web/cirq_ts' $@
+npm --prefix 'cirq-web/cirq_ts' "$@"

check/npx

@@ -26,4 +26,4 @@ cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
 cd 'cirq-web/cirq_ts'
-npx $@
+npx "$@"

check/pylint

@@ -14,4 +14,4 @@ cd "$(git rev-parse --show-toplevel)"
 CIRQ_MODULES=$(env PYTHONPATH=. python dev_tools/modules.py list --mode package-path)
 
 # Add dev_tools to $PYTHONPATH so that pylint can find custom checkers
-env PYTHONPATH=dev_tools pylint --rcfile=dev_tools/conf/.pylintrc $@ $CIRQ_MODULES dev_tools examples
+env PYTHONPATH=dev_tools pylint --rcfile=dev_tools/conf/.pylintrc "$@" $CIRQ_MODULES dev_tools examples

check/pytest

@@ -19,7 +19,7 @@ cd "$(git rev-parse --show-toplevel)"
 
 PYTEST_ARGS=()
 ACTUALLY_QUIET=""
-for arg in $@; do
+for arg in "$@"; do
     if [[ "${arg}" == "--actually-quiet" ]]; then
         ACTUALLY_QUIET=1
     else
@@ -48,4 +48,4 @@ if [ "$RESULT" = 5 ]; then
   exit 0
 fi
 
-exit "$RESULT"
+exit "$RESULT"

check/ts-build

@@ -25,4 +25,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-check/npx webpack --mode production $@
+check/npx webpack --mode production "$@"

check/ts-coverage

@@ -25,4 +25,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-check/npm run coverage $@
+check/npm run coverage "$@"

check/ts-lint

@@ -25,4 +25,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-check/npm run lint $@
+check/npm run lint "$@"

check/ts-lint-and-format

@@ -25,4 +25,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-check/npm run fix $@
+check/npm run fix "$@"

check/ts-test

@@ -27,4 +27,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-check/npm run test $@
+check/npm run test "$@"

check/ts-test-e2e

@@ -27,4 +27,4 @@
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$(git rev-parse --show-toplevel)"
 
-check/npm run test-e2e $@
+check/npm run test-e2e "$@"

dev_tools/pr_monitor.sh

@@ -54,4 +54,4 @@ cd "${repo_dir}"
 
 # Do the thing.
 export PYTHONPATH=${repo_dir}
-python3 ${repo_dir}/dev_tools/pr_monitor.py $@
+python3 ${repo_dir}/dev_tools/pr_monitor.py "$@"