Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should an IonDevice accept any qubit type? #3447

Closed
rmlarose opened this issue Oct 28, 2020 · 2 comments · Fixed by #4690
Closed

Should an IonDevice accept any qubit type? #3447

rmlarose opened this issue Oct 28, 2020 · 2 comments · Fixed by #4690
Assignees
Labels
architecture/ion-trap Ion trap quantum computer related issues area/devices kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@rmlarose
Copy link
Contributor

Some docstrings (here) state qubits are one a line, while others (here) state qubits are identified by their x, y location. I believe the latter is a typo due to the annotation.

If so, should __init__ raise an error if the input qubits are not LineQubits? (The at and neighbors_of methods assume LineQubits.)

@balopat balopat added architecture/ion-trap Ion trap quantum computer related issues area/devices kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on labels Oct 29, 2020
@balopat
Copy link
Contributor

balopat commented Nov 6, 2020

I agree - I think we should expect LineQubits - now we have an ion-computing expert, @dabacon can you chime in?

@dabacon
Copy link
Collaborator

dabacon commented Nov 16, 2021

@dabacon was off talking to money people but now he is back and much happier to not have to listen to quantum hype.

LineQubit makes the most sense, even though there is all to all connectivity, when addressing in hardware it makes sense to address on a line.

The documentation has been fixed, but probably good to be defensive and throw a TypeError in the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture/ion-trap Ion trap quantum computer related issues area/devices kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants