Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce LineQubit type for IonDevices #4690

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Enforce LineQubit type for IonDevices #4690

merged 4 commits into from
Nov 16, 2021

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Nov 16, 2021

Fixes #3447

@dabacon dabacon requested review from cduck, vtomole and a team as code owners November 16, 2021 02:05
@dabacon dabacon requested a review from tanujkhattar November 16, 2021 02:05
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 16, 2021
vtomole
vtomole approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vtomole
vtomole reviewed Nov 16, 2021
View reviewed changes
cirq-core/cirq/ion/ion_device.py Outdated
@@ -56,10 +56,18 @@ def __init__(
oneq_gates_duration: The maximum duration of a single qubit
operation.
qubits: Qubits on the device, identified by their x, y location.
Copy link
Collaborator

@vtomole vtomole Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove identified by their x, y location because it's not x,y location anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@CirqBot CirqBot added the size: S 10< lines changed <50 label Nov 16, 2021
@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 16, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 16, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Nov 16, 2021

Automerge cancelled: A required status check is not present.

Missing statuses: ['Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 16, 2021
@dabacon dabacon merged commit 1ea6061 into quantumlib:master Nov 16, 2021
@dabacon dabacon deleted the typeion branch April 16, 2022 15:42
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dabacon @rht
Enforce LineQubit type for IonDevices (quantumlib#4690)
00ad692
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@dabacon
Enforce LineQubit type for IonDevices (quantumlib#4690)
9dbe0ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should an IonDevice accept any qubit type?
3 participants
@dabacon @CirqBot @vtomole