We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeviceMetadata
Description of the issue
Args say qubits and nx_graph are optional, but their type is not Optional[].
qubits
nx_graph
Optional[]
Cirq/cirq-core/cirq/devices/device.py
Lines 224 to 231 in 6937e41
Args say the returned qubit set can be None but return type is not Optional[FrozenSet['cirq.Qid']].
None
Optional[FrozenSet['cirq.Qid']]
Lines 240 to 245 in 6937e41
Args say the returned graph can be None but return type is not Optional[nx.Graph].
Optional[nx.Graph]
Lines 249 to 253 in 6937e41
nx.graph is used as a type instead of nx.Graph -- the former is a module and latter is a type.
nx.graph
nx.Graph
Line 225 in 6937e41
Cirq version
0.14dev
cc @MichaelBroughton
The text was updated successfully, but these errors were encountered:
Devices
DeviceMetadata docs update. (#4963)
5eae221
Closes #4962
DeviceMetadata docs update. (quantumlib#4963)
4df1e52
Closes quantumlib#4962
0ae5741
85b9e00
MichaelBroughton
Successfully merging a pull request may close this issue.
Description of the issue
Args say
qubits
andnx_graph
are optional, but their type is notOptional[]
.Cirq/cirq-core/cirq/devices/device.py
Lines 224 to 231 in 6937e41
Args say the returned qubit set can be
None
but return type is notOptional[FrozenSet['cirq.Qid']]
.Cirq/cirq-core/cirq/devices/device.py
Lines 240 to 245 in 6937e41
Args say the returned graph can be
None
but return type is notOptional[nx.Graph]
.Cirq/cirq-core/cirq/devices/device.py
Lines 249 to 253 in 6937e41
nx.graph
is used as a type instead ofnx.Graph
-- the former is a module and latter is a type.Cirq/cirq-core/cirq/devices/device.py
Line 225 in 6937e41
Cirq version
cc @MichaelBroughton
The text was updated successfully, but these errors were encountered: