Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QubitPermutationGate should be json serializable and define a _decompose_ #5090

Closed
mpharrigan opened this issue Mar 17, 2022 · 1 comment · Fixed by #5093
Closed

QubitPermutationGate should be json serializable and define a _decompose_ #5090

mpharrigan opened this issue Mar 17, 2022 · 1 comment · Fixed by #5093
Labels
kind/bug-report Something doesn't seem to work.

Comments

@mpharrigan
Copy link
Collaborator

Right now, QubitPermutationGate cannot be resolved during deserialization. I don't think there's any big reason why it isn't. In fact: I would posit that it's really important that all gates be serializable.
@mpharrigan mpharrigan added the kind/bug-report Something doesn't seem to work. label Mar 17, 2022
@tanujkhattar tanujkhattar changed the title QubitPermutationGate should be json serializable QubitPermutationGate should be json serializable and define a _decompose_ Mar 17, 2022
@tanujkhattar
Copy link
Collaborator

It should also define a _decompose_ in terms of swaps.

@MichaelBroughton MichaelBroughton mentioned this issue Mar 17, 2022
Merged
CirqBot pushed a commit that referenced this issue Mar 17, 2022
@MichaelBroughton
Serialize QubitPermutationGate. (#5092)
c153664 
Step towards fixing #5090
@tanujkhattar tanujkhattar mentioned this issue Mar 17, 2022
Merged
CirqBot pushed a commit that referenced this issue Mar 18, 2022
@tanujkhattar
Add default decomposition for cirq.QubitPermutationGate in terms of a…
848bfde 
…djacent swaps (#5093)

- Adds decomposition to `cirq.QubitPermutationGate` in terms of minimum number of adjacent swap operations on qubits. 
- Part of #4858

Closes #5090
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this issue Apr 14, 2022
@tanujkhattar @tonybruguier
Add default decomposition for cirq.QubitPermutationGate in terms of a…
5aa5248 
…djacent swaps (quantumlib#5093)

- Adds decomposition to `cirq.QubitPermutationGate` in terms of minimum number of adjacent swap operations on qubits. 
- Part of quantumlib#4858

Closes quantumlib#5090
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Serialize QubitPermutationGate. (quantumlib#5092)
f38e849 
Step towards fixing quantumlib#5090
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@tanujkhattar @rht
Add default decomposition for cirq.QubitPermutationGate in terms of a…
cec87ed 
…djacent swaps (quantumlib#5093)

- Adds decomposition to `cirq.QubitPermutationGate` in terms of minimum number of adjacent swap operations on qubits. 
- Part of quantumlib#4858

Closes quantumlib#5090
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@MichaelBroughton
Serialize QubitPermutationGate. (quantumlib#5092)
2ea535d 
Step towards fixing quantumlib#5090
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@tanujkhattar
Add default decomposition for cirq.QubitPermutationGate in terms of a…
25de385 
…djacent swaps (quantumlib#5093)

- Adds decomposition to `cirq.QubitPermutationGate` in terms of minimum number of adjacent swap operations on qubits. 
- Part of quantumlib#4858

Closes quantumlib#5090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug-report Something doesn't seem to work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default decomposition for cirq.QubitPermutationGate in terms of adjacent swaps tanujkhattar/Cirq
2 participants
@mpharrigan @tanujkhattar