Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete coverage of aqt_device.py #5698

Closed
pavoljuhas opened this issue Jul 8, 2022 · 0 comments · Fixed by #5782
Closed

Complete coverage of aqt_device.py #5698

pavoljuhas opened this issue Jul 8, 2022 · 0 comments · Fixed by #5782
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

#5696 moves some uncovered code from ion_device.py (deleted) to aqt_device.py causing a CI coverage failure on the new lines. I have added a few # coverage: ignore comments to unblock the PR.

TODO: Fix this by adding tests that will complete the code coverage of aqt_device.py.
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Jul 8, 2022
@pavoljuhas pavoljuhas mentioned this issue Jul 15, 2022
Merged
CirqBot pushed a commit that referenced this issue Jul 16, 2022
@pavoljuhas
Move AQTTargetGateset to its own module (#5782)
7632fc5 
Add tests to complete test coverage of AQTTargetGateset.
Update `_decompose_single_qubit_operation` to check the
type of the wrapped gate, disregarding CircuitOperation
and TaggedOperation wrappers.

Fixes #5698
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@pavoljuhas @rht
Move AQTTargetGateset to its own module (quantumlib#5782)
6f6b648 
Add tests to complete test coverage of AQTTargetGateset.
Update `_decompose_single_qubit_operation` to check the
type of the wrapped gate, disregarding CircuitOperation
and TaggedOperation wrappers.

Fixes quantumlib#5698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move AQTTargetGateset to its own module pavoljuhas/Cirq
1 participant
@pavoljuhas