Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split right multiplication into separate methods in StabilizerStateCHForm #3259

Merged
merged 8 commits into from
Sep 10, 2020
Merged

Split right multiplication into separate methods in StabilizerStateCHForm #3259

merged 8 commits into from
Sep 10, 2020

Conversation

smitsanghavi
Copy link
Collaborator

@smitsanghavi smitsanghavi commented Aug 21, 2020 •
edited
Loading

#2423

This will allow each method to have a definite action which will allow us to move the left multiplication logic to individual gates #2948. Also makes the update_sum method public so that the gates can call it instead of duplicating the logic.

@smitsanghavi
Simplify StabilizerStateCHForm implementation by removing "right" par…
6b31295 
…ams and add support for negative initial state
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Aug 21, 2020
@smitsanghavi smitsanghavi requested a review from balopat August 21, 2020 06:00
@smitsanghavi smitsanghavi added the Ready for Re-Review For when reviewers take their time. label Aug 26, 2020
balopat
balopat suggested changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for splitting this out! I have questions.

cirq/sim/clifford/stabilizer_state_ch_form.py Show resolved Hide resolved
cirq/sim/clifford/stabilizer_state_ch_form.py Show resolved Hide resolved
cirq/sim/clifford/stabilizer_state_ch_form.py Outdated Show resolved Hide resolved
@balopat balopat removed the Ready for Re-Review For when reviewers take their time. label Aug 26, 2020
balopat
balopat approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this mostly looks good, I just have small questions

balopat
balopat suggested changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the comments before going forward.

@smitsanghavi smitsanghavi changed the title Simplify StabilizerStateCHForm implementation and add support for negative initial state Split right multiplication into separate methods in StabilizerStateCHForm Sep 6, 2020
@smitsanghavi smitsanghavi requested a review from balopat September 6, 2020 03:58
@smitsanghavi smitsanghavi added the Ready for Re-Review For when reviewers take their time. label Sep 8, 2020
@balopat balopat added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed Ready for Re-Review For when reviewers take their time. labels Sep 10, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 10, 2020
@CirqBot CirqBot merged commit 55502f1 into quantumlib:master Sep 10, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smitsanghavi @balopat @googlebot @CirqBot