Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform CliffordState measurements via method dispatch #3503

Merged
merged 10 commits into from
Jan 7, 2021
Merged

Perform CliffordState measurements via method dispatch #3503

merged 10 commits into from
Jan 7, 2021

Conversation

smitsanghavi
Copy link
Collaborator

@smitsanghavi smitsanghavi commented Nov 13, 2020 •
edited
Loading

And deprecate the old perform_measurement method that called the _measure method directly.

Also deprecate all uses of CliffordTableau inside the CliffordState. Full clean up will follow.

#2948 #2423

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 13, 2020
@smitsanghavi smitsanghavi linked an issue Nov 13, 2020 that may be closed by this pull request
Update CliffordSimulator state through method dispatch on Gates #2948
Closed
@smitsanghavi smitsanghavi requested a review from balopat November 13, 2020 09:30
smitsanghavi
smitsanghavi commented Nov 16, 2020
View reviewed changes
cirq/sim/clifford/clifford_simulator.py

for i, qid in enumerate(qids):
state.ch_form.project_Z(qid, measurements[key][i])

@deprecated_parameter(
Copy link
Collaborator Author

@smitsanghavi smitsanghavi Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the whole function is deprecated now, should I remove the param deprecation annotation?

@smitsanghavi
Copy link
Collaborator Author

Friendly Ping!

@smitsanghavi
Copy link
Collaborator Author

Holding off on this PR for now

@smitsanghavi smitsanghavi marked this pull request as draft December 2, 2020 09:04
@smitsanghavi smitsanghavi mentioned this pull request Dec 14, 2020
Merged
@smitsanghavi smitsanghavi marked this pull request as ready for review December 23, 2020 01:58
@smitsanghavi smitsanghavi requested review from cduck, vtomole and a team as code owners December 23, 2020 01:58
@smitsanghavi smitsanghavi requested a review from balopat December 23, 2020 19:14
@smitsanghavi
Copy link
Collaborator Author

Ping!

@smitsanghavi smitsanghavi added the Ready for Re-Review For when reviewers take their time. label Dec 29, 2020
@smitsanghavi smitsanghavi requested a review from balopat January 4, 2021 05:24
balopat
balopat approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@balopat balopat added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed Ready for Re-Review For when reviewers take their time. labels Jan 7, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 7, 2021
@CirqBot CirqBot merged commit 9bad962 into quantumlib:master Jan 7, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CliffordSimulator state through method dispatch on Gates
3 participants
@smitsanghavi @balopat @CirqBot