Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add measurement support to ActOnStabilizerChFormArgs and use it in MeasurementGate #3610

Merged
merged 6 commits into from
Dec 23, 2020
Merged

Add measurement support to ActOnStabilizerChFormArgs and use it in MeasurementGate #3610

merged 6 commits into from
Dec 23, 2020

Conversation

smitsanghavi
Copy link
Collaborator

@smitsanghavi smitsanghavi commented Dec 15, 2020 •
edited
Loading

@smitsanghavi smitsanghavi requested review from cduck, vtomole and a team as code owners December 15, 2020 02:40
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Dec 15, 2020
@smitsanghavi
Copy link
Collaborator Author

Friendly Ping!

balopat
balopat approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Smit! LGTM - with two nits

cirq/sim/clifford/act_on_stabilizer_ch_form_args.py Outdated Show resolved Hide resolved
cirq/sim/clifford/act_on_stabilizer_ch_form_args.py Show resolved Hide resolved
@balopat
Copy link
Contributor

balopat commented Dec 22, 2020

Notebook failure is due to #3625

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 23, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 23, 2020
@CirqBot CirqBot merged commit 0b58a1a into quantumlib:master Dec 23, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 23, 2020
@smitsanghavi smitsanghavi deleted the measg branch December 23, 2020 01:11
@smitsanghavi smitsanghavi mentioned this pull request Dec 23, 2020
Merged
CirqBot pushed a commit that referenced this pull request Dec 23, 2020
@smitsanghavi
Avoid going through CliffordSimulator to test `StabilizerStateChFor…
f98ece8 
…m` (#3628)

#2423 

Now that measurements are supported through StablizerStateChForm from MeasurementGate in #3610, we don't need the help of `CliffordSimulator` to test its behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitsanghavi @balopat @CirqBot