Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clifford Tableau decomposition function #4183
Add Clifford Tableau decomposition function #4183
Changes from 9 commits
b2d9269
0234dda
7596136
03dc632
b5cffae
b7b7170
20760c2
4ede0af
a076caa
1a2ef9b
9f87a05
56a536e
31a30bf
a5bf003
6c2a9a3
3121748
566db2f
9d0dbd1
ad20805
ea0af8e
2573664
131636e
db940ed
67147e3
9f7ce6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can reuse the implementation of
assert_implements_consistent_protocols
incirq.testing.consistent_protocols
? It does have a decomposition consistent with unitary assertion...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a brief look of this function, I think it is more suitable to put into the
n_qubit_clifford_gate
class, which is the next step when all these Clifford Tableau helper functions are done. Wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that can work - and will be consistent with having
Gate
s having a decomposition - but on the other hand there is nothing wrong with having it on the tableau and then theGate
delegating to the tableau's method, so I think I'm okay to have it here, as this way the Aaaronson-Gottesman paper implementations are kept closer together.