Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test deserializer on infinite recursion. #4315

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Test deserializer on infinite recursion. #4315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b91d9ca
Test deserializer on infinite recursion.
95-martin-orion Jul 12, 2021
85ae777
Merge branch 'master' into cirq-subcirq-finite
95-martin-orion Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions cirq-google/cirq_google/serializable_gate_set_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,48 @@ def test_serialize_deserialize_circuit_with_subcircuit():
assert MY_GATE_SET.deserialize(proto) == circuit


def test_deserialize_infinite_recursion_fails():
inf_op = cirq.CircuitOperation(cirq.FrozenCircuit())
# Maliciously modify the CircuitOperation to be self-referencing.
setattr(inf_op.circuit, '_moments', tuple(cirq.Circuit(inf_op).moments))
circuit = cirq.Circuit(inf_op)
with pytest.raises(RecursionError):
_ = MY_GATE_SET.serialize(circuit)

c_op1 = v2.program_pb2.CircuitOperation()
c_op1.circuit_constant_index = 0
rep_spec = c_op1.repetition_specification
rep_spec.repetition_count = 2
rep_spec.repetition_ids.ids.extend(['a', 'b'])

# This proto is illegal: c_op1 references a constant containing c_op1.
proto = v2.program_pb2.Program(
language=v2.program_pb2.Language(arg_function_language='', gate_set='my_gate_set'),
circuit=v2.program_pb2.Circuit(
scheduling_strategy=v2.program_pb2.Circuit.MOMENT_BY_MOMENT,
moments=[
v2.program_pb2.Moment(
circuit_operations=[c_op1],
),
],
),
constants=[
v2.program_pb2.Constant(
circuit_value=v2.program_pb2.Circuit(
scheduling_strategy=v2.program_pb2.Circuit.MOMENT_BY_MOMENT,
moments=[
v2.program_pb2.Moment(
circuit_operations=[c_op1],
),
],
)
),
],
)
with pytest.raises(ValueError, match="Failed to deserialize circuit"):
_ = MY_GATE_SET.deserialize(proto)


def test_deserialize_bad_operation_id():
proto = v2.program_pb2.Program(
language=v2.program_pb2.Language(arg_function_language='', gate_set='my_gate_set'),
Expand Down