Fix str/repr explosion in separated states

[daxfohl]

Fixes #4477 by outputting separated states individually rather than kronning them all together first.

[daxfohl]

@95-martin-orion FWIW I think before cirq 1.0 we should get rid of all the extra MySimulatorStepResult and MySimulatorTrialResult classes, and just yield/return TActOnArgs as the result (renamed to TSimulatorState). I don't see any value added by the various StepResult and TrialResult classes, but they add a bunch of unnecessary code obfuscation.

Obviously a big breaking change.....

[95-martin-orion]

Looks good to go. Let me know when you're ready to merge, in case there's any issues colliding with your other PRs in flight.

[95-martin-orion]

@95-martin-orion FWIW I think before cirq 1.0 we should get rid of all the extra MySimulatorStepResult and MySimulatorTrialResult classes, {...}

Could you open an issue and CC @MichaelBroughton on it? There's a laundry list of TODOs like this somewhere that he's been keeping track of.

[daxfohl]

This can be merged.

…

On Mon, Dec 20, 2021 at 2:20 PM Orion Martin ***@***.***> wrote: ***@***.**** approved this pull request. Looks good to go. Let me know when you're ready to merge, in case there's any issues colliding with your other PRs in flight. — Reply to this email directly, view it on GitHub <#4518 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG464OAPY4CRFR32XD7EA3UR6T4JANCNFSM5ET4AEAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[CirqBot]

Automerge cancelled: A status check is failing.

[95-martin-orion]

Looks like the rigetti/quilc install timed out. Will retry as soon as I figure out how to trigger it.

[95-martin-orion]

Looks like an ongoing Docker outage is breaking us: https://downdetector.com/status/docker/

We'll need to wait it out before merging.

[daxfohl]

Looks like it's up again

[verult]

Hi @daxfohl , I tried running the following:

>>> q = cirq.GridQubit(0,0)
>>> c = cirq.Circuit(cirq.H(q))
>>> sim = cirq.Simulator()
>>> r = sim.simulate(c)
>>> print(r)
measurements: (no measurements)

qubits: (cirq.GridQubit(0, 0),)
output vector: 0.707|0⟩ + 0.707|1⟩

phase:
output vector: |⟩

Is the phase output expected? I was surprised to see an output vector after "phase" but I might be misunderstanding something. Thanks!

[daxfohl]

There is a phase component. Try adding a global phase and see how it changes? I can't remember. Maybe there's a better way to output the phase.

[verult]

I appended a cirq.global_phase_operation(-1) and got this:

phase:
output vector: -1|⟩

Would it make sense to just have the phase in the output and remove the output vector part?

[daxfohl]

Yes that would probably make more sense :)