Flush v0.14.0 deprecation backlog. #4601

MichaelBroughton · 2021-10-26T22:42:06Z

Removed cirq.<vendor> to cirq_<vendor> deprecations (This required some repr_inward changes as well as some renaming in cirq_pasqal).
Removed ParallelGateOperation.
Removed cirq.Two/ThreeQubitGate. We still have cirq.testing.Two/ThreeQubitGate.
Removed SupportsOnEachGate.
Removed allow_decompose parameter from measurement_key_names and is_measurement.
Removed kraus_to_channel_matrix, operation_to_channel_matrix.
Removed asynchronous_pending and cirq-core/cirq/testing/asynchronous.py.
Removed gate_set_name in favor of name from serializable_gate_set.py

@mpharrigan can you double check my changes on the json items.

BREAKING CHANGE= some features of ParallelGateOperation aren't fully convertible. i.e. cirq.num_qubits(old_op.gate) != cirq.num_qubits(new_op.gate) and isinstance(old_op, GateOperation) != isinstance(new_op, GateOperation)

review-notebook-app · 2021-10-26T22:42:10Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

cirq-core/cirq/json_resolver_cache.py

mpharrigan

I'm confused about the repr_inwards

cirq-google/cirq_google/json_test_data/SycamoreGate.repr_inward

mpharrigan

don't remove the json_inward files

MichaelBroughton · 2021-10-27T23:20:47Z

If I get rid of the repr_inward and leave just the json_inward, the json_inward tests complain there is no corresponding repr_inward file. I think I either need to keep both and do the rename in the repr_inwards or get rid of both. Maybe it makes sense to just keep both and do the rename ?

mpharrigan · 2021-10-27T23:40:22Z

If the json_inward tests require the repr_inward files, then yes: keep them and use the new cirq_google spelling therein

mpharrigan

no blockers from me

tanujkhattar · 2021-10-28T21:38:24Z

cirq-core/cirq/json_resolver_cache.py

@@ -112,7 +116,7 @@ def two_qubit_matrix_gate(matrix):
        '_PauliY': cirq.ops.pauli_gates._PauliY,
        '_PauliZ': cirq.ops.pauli_gates._PauliZ,
        'ParamResolver': cirq.ParamResolver,
-        'ParallelGateOperation': cirq.ParallelGateOperation,
+        'ParallelGateOperation': _parallel_gate_op,  # Removed in v0.14


FYI: The two classes are not strictly interchangeable (i.e. ParallelGateOperation vs ParallelGate().on()) and can result in breakages in the user code after this substitution. Though I'm not sure we have a better backward compatible alternative at this point.

Should we add a breaking change tag and outline some more details here so we remember for next release ?

docs/tutorials/fourier_checking.ipynb

tanujkhattar · 2021-10-28T21:43:31Z

docs/custom_gates.ipynb

-   "outputs": [
-    {
-     "name": "stdout",
-     "output_type": "stream",
-     "text": [
-      "Circuit with custom gates:\n",
-      "0: ───G───\n"
-     ]
-    }
-   ],


Is it expected to get rid of these output cells? It would change the way these colabs are rendered on the website?

It won't change the way the notebooks are rendered on the site. If the outputs on the notebook are given, then the site will use those, otherwise it will just run the notebook and use that output. Typically we'd only want fixed outputs if things needed it due to things like randomness in the notebook or certain outputs looking bad. I couldn't see a reason why we needed the fixed output here

tanujkhattar

LGTM % nits.

mpharrigan · 2021-10-29T18:04:18Z

I find the breaking change label funny here. Clearly removing a host of stuff is a breaking change, albeit through the deprecation cycle. I guess you want to call attention to the fact that one of the deprecated items doesn't have a lossless, automated migration?

@mpharrigan

Removed `cirq.<vendor>` to `cirq_<vendor>` deprecations (This required some repr_inward changes as well as some renaming in `cirq_pasqal`). Removed `ParallelGateOperation`. Removed `cirq.Two/ThreeQubitGate`. We still have `cirq.testing.Two/ThreeQubitGate`. Removed `SupportsOnEachGate`. Removed `allow_decompose` parameter from `measurement_key_names` and `is_measurement`. Removed `kraus_to_channel_matrix`, `operation_to_channel_matrix`. Removed `asynchronous_pending` and `cirq-core/cirq/testing/asynchronous.py`. Removed `gate_set_name` in favor of `name` from `serializable_gate_set.py` @mpharrigan can you double check my changes on the json items. BREAKING CHANGE= some features of ParallelGateOperation aren't fully convertible. i.e. `cirq.num_qubits(old_op.gate) != cirq.num_qubits(new_op.gate)` and `isinstance(old_op, GateOperation) != isinstance(new_op, GateOperation)`

@mpharrigan

Removed `cirq.<vendor>` to `cirq_<vendor>` deprecations (This required some repr_inward changes as well as some renaming in `cirq_pasqal`). Removed `ParallelGateOperation`. Removed `cirq.Two/ThreeQubitGate`. We still have `cirq.testing.Two/ThreeQubitGate`. Removed `SupportsOnEachGate`. Removed `allow_decompose` parameter from `measurement_key_names` and `is_measurement`. Removed `kraus_to_channel_matrix`, `operation_to_channel_matrix`. Removed `asynchronous_pending` and `cirq-core/cirq/testing/asynchronous.py`. Removed `gate_set_name` in favor of `name` from `serializable_gate_set.py` @mpharrigan can you double check my changes on the json items. BREAKING CHANGE= some features of ParallelGateOperation aren't fully convertible. i.e. `cirq.num_qubits(old_op.gate) != cirq.num_qubits(new_op.gate)` and `isinstance(old_op, GateOperation) != isinstance(new_op, GateOperation)`

Flush v0.14.0 deprecation backlog.

c89da83

MichaelBroughton requested review from cduck, HGSilveri, vtomole, wcourtney and a team as code owners October 26, 2021 22:42

MichaelBroughton requested a review from mpharrigan October 26, 2021 22:42

google-cla bot added the cla: yes Makes googlebot stop complaining. label Oct 26, 2021

CirqBot added the size: XL lines changed >1000 label Oct 26, 2021

mpharrigan reviewed Oct 26, 2021

View reviewed changes

cirq-core/cirq/json_resolver_cache.py Outdated Show resolved Hide resolved

mpharrigan reviewed Oct 26, 2021

View reviewed changes

cirq-core/cirq/json_resolver_cache.py Show resolved Hide resolved

mpharrigan requested changes Oct 26, 2021

View reviewed changes

cirq-google/cirq_google/json_test_data/SycamoreGate.repr_inward Show resolved Hide resolved

mpharrigan requested changes Oct 27, 2021

View reviewed changes

re-revert ***_inwards.

2dc7527

MichaelBroughton force-pushed the v14_flush branch from 0b150f9 to 2dc7527 Compare October 28, 2021 06:03

mpharrigan approved these changes Oct 28, 2021

View reviewed changes

tanujkhattar reviewed Oct 28, 2021

View reviewed changes

docs/tutorials/fourier_checking.ipynb Outdated Show resolved Hide resolved

tanujkhattar reviewed Oct 28, 2021

View reviewed changes

tanujkhattar approved these changes Oct 28, 2021

View reviewed changes

MichaelBroughton added 2 commits October 28, 2021 16:46

Tanuj feedback.

e231f28

added missing *

6527134

MichaelBroughton added BREAKING CHANGE For pull requests that are important to mention in release notes. automerge Tells CirqBot to sync and merge this PR. (If it's running.) labels Oct 29, 2021

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 29, 2021

Merge branch 'master' into v14_flush

a3326b9

CirqBot merged commit 21b9be3 into quantumlib:master Oct 29, 2021

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 29, 2021

MichaelBroughton deleted the v14_flush branch October 29, 2021 17:51

pavoljuhas mentioned this pull request Apr 10, 2024

Error in using Class TwoQubitGate #6557

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flush v0.14.0 deprecation backlog. #4601

Flush v0.14.0 deprecation backlog. #4601

MichaelBroughton commented Oct 26, 2021 •

edited

Loading

review-notebook-app bot commented Oct 26, 2021

mpharrigan left a comment

mpharrigan left a comment

MichaelBroughton commented Oct 27, 2021

mpharrigan commented Oct 27, 2021

mpharrigan left a comment

tanujkhattar Oct 28, 2021

MichaelBroughton Oct 28, 2021

tanujkhattar Oct 28, 2021

MichaelBroughton Oct 28, 2021 •

edited

Loading

tanujkhattar left a comment

mpharrigan commented Oct 29, 2021

Flush v0.14.0 deprecation backlog. #4601

Flush v0.14.0 deprecation backlog. #4601

Conversation

MichaelBroughton commented Oct 26, 2021 • edited Loading

review-notebook-app bot commented Oct 26, 2021

mpharrigan left a comment

Choose a reason for hiding this comment

mpharrigan left a comment

Choose a reason for hiding this comment

MichaelBroughton commented Oct 27, 2021

mpharrigan commented Oct 27, 2021

mpharrigan left a comment

Choose a reason for hiding this comment

tanujkhattar Oct 28, 2021

Choose a reason for hiding this comment

MichaelBroughton Oct 28, 2021

Choose a reason for hiding this comment

tanujkhattar Oct 28, 2021

Choose a reason for hiding this comment

MichaelBroughton Oct 28, 2021 • edited Loading

Choose a reason for hiding this comment

tanujkhattar left a comment

Choose a reason for hiding this comment

mpharrigan commented Oct 29, 2021

MichaelBroughton commented Oct 26, 2021 •

edited

Loading

MichaelBroughton Oct 28, 2021 •

edited

Loading