Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken RFC link in "Cirq Triage" page #4604

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

augustehirth
Copy link
Collaborator

@augustehirth augustehirth commented Oct 28, 2021

Add "https://" to first link to make it into an external link, so it resolves to
"https://bit.do/cirq-triage" instead of
"https://quantumai.google/cirq/dev/bit.do/cirq-triage".

@augustehirth augustehirth requested review from cduck, vtomole and a team as code owners October 28, 2021 02:55
@augustehirth augustehirth requested a review from viathor October 28, 2021 02:55
@CirqBot CirqBot added the Size: XS <10 lines changed label Oct 28, 2021
@google-cla
Copy link

google-cla bot commented Oct 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 28, 2021
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please sign the CLA.

@augustehirth
Copy link
Collaborator Author

CLA is in-progress. Will have it done asap

@dabacon
Copy link
Collaborator

dabacon commented Nov 17, 2021

@augustehirth any word on the CLA? silly legal stuff, but would like to get this in :)

@augustehirth
Copy link
Collaborator Author

CLA status is moving forwards, but very slowly. Thanks for your patience.

@google-cla google-cla bot added cla: yes Makes googlebot stop complaining. and removed cla: no labels Jan 21, 2022
@augustehirth augustehirth merged commit 39ce4f0 into quantumlib:master Jan 21, 2022
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
@augustehirth augustehirth deleted the cirq_triage_rfc_link_fix branch June 6, 2022 19:23
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants