Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json serialize MSGate #4605

Merged
merged 10 commits into from
Oct 29, 2021
Merged

Json serialize MSGate #4605

merged 10 commits into from
Oct 29, 2021

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Oct 28, 2021 •
edited
Loading

Fixes #4603

@vtomole vtomole requested review from cduck and a team as code owners October 28, 2021 19:47
@vtomole vtomole requested a review from tanujkhattar October 28, 2021 19:47
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Oct 28, 2021
@CirqBot CirqBot added the size: S 10< lines changed <50 label Oct 28, 2021
@vtomole vtomole mentioned this pull request Oct 28, 2021
Closed
@vtomole vtomole changed the title Serialize MSGate Json serialize MSGate Oct 28, 2021
@vtomole @tanujkhattar
Update cirq-core/cirq/ion/ion_gates.py
533e71a 
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
tanujkhattar
tanujkhattar approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 29, 2021
@CirqBot CirqBot merged commit c7d420b into quantumlib:master Oct 29, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 29, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@vtomole @rht
Json serialize MSGate (quantumlib#4605)
141ec57 
Fixes quantumlib#4603
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@vtomole
Json serialize MSGate (quantumlib#4605)
e61b006 
Fixes quantumlib#4603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Json serialize cirq.ion.ion_gates.MSGate
3 participants
@vtomole @tanujkhattar @CirqBot